Skip LogAndMetricis test when running on firecracker version >1.4.x #565
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Swagat Bora <sbora@amazon.com>
austinvazquez
approved these changes
May 7, 2024
henry118
approved these changes
May 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Firecracker logging behavior has changed after v1.5.0. This causes CI test failures when running against latest Firecracker version.
Description of changes:
Update test to skip if not running against v1.4.x
Testing
https://buildkite.com/firecracker-microvm/firecracker-go-sdk/builds/3652
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.