Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestLogAndMetrics #555

Merged

Conversation

swagatbora90
Copy link
Contributor

Issue #, if available:
TestLogAndMetrics/Error currently fails with Error

=== CONT  TestLogAndMetrics/Error
    machine_test.go:469:
        	Error Trace:	/local/home/buildkite-agent/builds/ip-10-0-0-92-30/firecracker-microvm/firecracker-go-sdk-amd/machine_test.go:469
        	Error:      	Expect "" to match "^Running Firecracker v\d+\.\d+[\.-]"
        	Test:       	TestLogAndMetrics/Error

After looking into the code, looks like there has been a recent change in Firecracker to fix the logger behavior. firecracker-microvm/firecracker#4171. After the change, the log-level passed to Firecracker is respected, so when we pass "Error" loglevel, the info message does not get printed

Description of changes:
The "Running Firecracker v\d+.\d+[.-]" log should be written to fc.logs when loglevel is set to INFO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Swagat Bora <sbora@amazon.com>
@swagatbora90 swagatbora90 requested a review from a team as a code owner April 11, 2024 18:40
@swagatbora90 swagatbora90 merged commit 3ee6ca2 into firecracker-microvm:main Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants