Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
TestLogAndMetrics/Error currently fails with Error
After looking into the code, looks like there has been a recent change in Firecracker to fix the logger behavior. firecracker-microvm/firecracker#4171. After the change, the log-level passed to Firecracker is respected, so when we pass "Error" loglevel, the info message does not get printed
Description of changes:
The "Running Firecracker v\d+.\d+[.-]" log should be written to fc.logs when loglevel is set to INFO
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.