Allow --cgroup to be passed to jailer
#493
Open
+41
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gudmundur Bjarni Olafsson <gudmundur.bjarni@gmail.com>
Signed-off-by: Gudmundur Bjarni Olafsson <gudmundur.bjarni@gmail.com>
Signed-off-by: Gudmundur Bjarni Olafsson <gudmundur.bjarni@gmail.com>
gudmundur
force-pushed
the
jailer-configurable-cgroups
branch
from
7ef891b
to
a254341
Compare
Signed-off-by: Guðmundur Bjarni Ólafsson <gudmundur.bjarni@gmail.com>
Signed-off-by: Guðmundur Bjarni Ólafsson <gudmundur.bjarni@gmail.com>
|
👋 I'm wanting the same thing, any reason you decided to not pursue this change? Is there a better way to configure cgroups via the SDK? |
|
Likewise, would love to see this in. |
|
@adityamaru we're using this in production. Waiting for a maintainer here to review this. 😳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: When setting up the
jailerviafirecracker-go-sdkI noticed that the SDK only supported setting aWithNumaNodeto provide affinity. This change allows theWithNumaNodeto be optional, which it is with thejailer. This change also adds aWithCgroupArgsoption that will pass the provided arguments through tojailers--cgroupargument.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.