Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve kernel argument ordering #487

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DZDomi
Copy link

@DZDomi DZDomi commented Mar 16, 2023

Currently the SDK uses a map for storing the kernel arguments. This map will then be serialised back into a string before it is passed to the firecracker process. Since the iteration of a map in go is random and not deterministic the kernel params will be given in any order, which can result in a failure in the following case:

When passing init arguments to the kernel with the -- flag the SDK will save it correctly in the map, but after turning it back into a string the order of the arguments is not correct.

As an example with the following arguments:

reboot=k panic=-1 quiet loglevel=1 console=ttyS0 -- --argument-for-init ENV_FOR_INIT=somevalue

Before the fix this could result in:

reboot=k -- panic=-1  ENV_FOR_INIT=somevalue quiet loglevel=1 console=ttyS0 --argument-for-init

Which would not pass these arguments into the init or even worse prevents the VM from starting.

After the fix the order of the arguments is always preserved and will be given like this to the kernel:

reboot=k panic=-1 quiet loglevel=1 console=ttyS0 -- --argument-for-init ENV_FOR_INIT=somevalue

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@DZDomi DZDomi requested a review from a team as a code owner March 16, 2023 18:24
Signed-off-by: Dominik De Zordo <dominik@trality.com>
Signed-off-by: Dominik De Zordo <dominik@trality.com>
Signed-off-by: Dominik De Zordo <dominik@trality.com>
Signed-off-by: Dominik De Zordo <dominik@trality.com>
@DZDomi DZDomi force-pushed the fix/kernel-args-preserve-ordering branch from 022e877 to 4f469e1 Compare March 16, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant