Allow cni runtime capabilities to be configuratble from CNIConfiguration #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change we add CapabilityArgs into the CNIConfiguration to allow CNI runtime capabilities to be configurable from the firecracker-go-sdk. Signed-off-by: Jingkai He <jingkai@hey.com>
jingkaihe
commented
Jul 31, 2021
| - 'go get github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap' | ||
| # Install tc-redirect-tap and portmap | ||
| - go get github.com/awslabs/tc-redirect-tap/cmd/tc-redirect-tap | ||
| - go get github.com/containernetworking/plugins/plugins/meta/portmap |
There was a problem hiding this comment.
added portmap due to buildkite complained about
failed to find plugin "portmap" in path [/opt/cni/bin /tmp/buildkite_build_1885_testdata/bin]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce CapabilityArgs into the CNIConfiguration to allow CNI runtime capabilities to be
configurable from the firecracker-go-sdk.
Here are a few useful use cases: https://github.com/containernetworking/cni/blob/master/CONVENTIONS.md#well-known-capabilities (in my specific use case it's the
portMappings).Signed-off-by: Jingkai He jingkai@hey.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.