upgrade to node 18 or 20, fix up linting

firebase · Jan 2, 2024 · ea648bb · ea648bb
1 parent 99d6454
commit ea648bb
Show file tree

Hide file tree

Showing 3 changed files with 1,054 additions and 6,025 deletions.
diff --git a/.eslintrc.yaml b/.eslintrc.yaml
@@ -1,8 +1,8 @@
 root: true
 extends: 
   - eslint:recommended
-  - plugin:@typescript-eslint/recommended
-  - plugin:@typescript-eslint/recommended-requiring-type-checking
+  - plugin:@typescript-eslint/recommended-type-checked
+  - plugin:@typescript-eslint/stylistic-type-checked
   - plugin:jsdoc/recommended
   - google
   - plugin:prettier/recommended
@@ -32,13 +32,22 @@ overrides:
   - files: 
       - "*.ts"
     rules:
+      "@typescript-eslint/array-type": warn
+      "@typescript-eslint/consistent-indexed-object-style": warn
+      "@typescript-eslint/no-explicit-any": warn
+      "@typescript-eslint/prefer-for-of": warn
+      "@typescript-eslint/prefer-nullish-coalescing": warn
+      "@typescript-eslint/prefer-optional-chain": warn
       "@typescript-eslint/no-unsafe-argument": warn # TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-assignment": warn # TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-call": warn # TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-member-access": warn # TODO(bkendall): remove allow to error.
   - files:
       - "*.js"
     rules:
+      "@typescript-eslint/prefer-for-of": warn
+      "@typescript-eslint/prefer-nullish-coalescing": warn
+      "@typescript-eslint/prefer-optional-chain": warn
       "@typescript-eslint/no-empty-function": warn # TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-this-alias": warn # TODO(bkendall): remove allow to error.
       "@typescript-eslint/no-unsafe-argument": warn # TODO(bkendall): remove allow to error.