fix(cloud_firestore_odm): add support for searching Enums #8386

mrorabau · 2022-04-03T00:15:09Z

Description

This PR should add support for searching Enums [.whereMyEnum()]. Previously using an Enum in a model would be stored and retrieved, but then it couldn't be searched on.

Related Issues

Closes #8338

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
All existing and new tests are passing.
I updated/added relevant documentation (doc comments with ///).
The analyzer (melos run analyze) does not report any problems on my PR.
I read and followed the Flutter Style Guide.
I signed the CLA.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change.
No, this is not a breaking change.

google-cla · 2022-04-03T00:15:15Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

rrousselGit · 2022-04-04T12:17:00Z

Hello!

Could you add tests for this? Thanks 😄

mrorabau · 2022-04-06T16:38:35Z

@rrousselGit I will try and add a test next week if you would like. I wasn't sure if you wanted to review it first. (I'm out of town at the moment, sorry I can't do it sooner).

google-oss-bot · 2022-04-22T01:03:17Z

Hey @mrorabau. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.

If you have more information that will help us get to the bottom of this, just add a comment!

mrorabau · 2022-04-28T00:24:39Z

@google-oss-bot I'm working on the tests (as requested). Having some issues.

mrorabau · 2022-05-15T17:06:44Z

@rrousselGit If you could take a look at this and see what else is needed. I tried to use the same type of tests you had, however it seems that it only tests for expected compile errors.

mrorabau · 2022-05-16T17:19:13Z

@Salakar
Thanks. I'll look into the error (unless you see it quickly). It is strange that I didn't get that on my end before submitting. There was a merge conflict, but I thought I resolved it.

russellwheatley · 2022-05-18T15:30:24Z

Hey @mrorabau, I'm not sure what is happening but you've reformatted the entirety of the iOS code base 🤔. Do you mind updating to the latest flutter stable (3.0.0), clang-format & swiftformat and running melos run format, please?

mrorabau · 2022-05-18T23:55:27Z

Do you mind updating to the latest flutter stable (3.0.0), clang-format & swiftformat and running melos run format, please?

@rrousselGit
Yeah, I will run it again (I'm on 3.0.0 now). I noticed that it reformatted (almost) everything, but it was the melos run format that did it (I followed the instructions to submit it). Any chance that you have a wider column set somewhere that isn't in the repo? I ask because it seemed that almost all of the format changes were wrapping related.

mrorabau · 2022-05-23T00:10:51Z

@rrousselGit
Sorry if I'm bugging you, but a couple of things:

The automated apple tests appear to be failing because of an emulator problem
The test "test/document_reference_test.dart" works for me, but fails in the automated test

The Apple/MacOS files still get formatted wrong. Maybe it has something to do with the line-wrap? It seems that the code in master is not wrapped as early as it does for me.
- flutter_plugin_tools 0.8.6
- swiftformat 0.49.9
- clang-format 14.0.4-++20220520113355+5f66e721ec1d-1~~exp1~~20220520113441.138

mrorabau · 2022-07-08T04:08:29Z

@rrousselGit
I did a clean checkout and moved only the files I modified and did not run the formatter so the IOS files are no longer modified by whatever in the swift formatter caused it to go crazy.

rrousselGit · 2022-07-09T14:58:00Z

Hello!
I'll review it next week. I'd like to merge the other pending ODM PRs first

rrousselGit · 2022-07-12T07:38:04Z

I don't have the permission to push to your PR. Could you fix the conflicts?

mrorabau · 2022-07-13T01:55:51Z

Hi Remi, I've de-conflicted it. So please take a look. BTW, your updates I think will help a lot. I had started a fix for timestamps/datetime but it looks like you already got to that.

…

-mark

On Tue, Jul 12, 2022 at 3:38 AM Remi Rousselet ***@***.***> wrote: I don't have the permission to push to your PR. Could you fix the conflicts? — Reply to this email directly, view it on GitHub <#8386 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANWRA5HLNKE3DRJM7LUWITVTUOGTANCNFSM5SMIEBKA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

rrousselGit · 2022-07-13T12:10:17Z

packages/cloud_firestore_odm/cloud_firestore_odm_generator/lib/src/collection_generator.dart

@@ -413,6 +414,7 @@ extension on DartType {
        generic.isDartCoreString ||
        generic.isDartCoreBool ||
        generic.isDartCoreObject ||
+        generic.element?.kind == ElementKind.ENUM ||


I don't see a test for List<MyEnum>. Could you add one? 😄

Remi,

First, I'm sorry for the delay, but I was trying to test the latest build against our project and it took me a while to figure out that we now seem to need a build.yaml in our own project in order to set the create_field_map=true. Otherwise it produces a bunch of errors. I didn't (currently) see this in the docs. I think if this is a requirement going forward it really needs to by highlighted.

I also changed "dart pub get" to "flutter pub get" in melos.yaml/odm:generator_test_build_runner:build (It was giving me a lot of headaches)

I added List to the Nested collection. Is that sufficient for the List test?

Thanks for your support!

Thanks for your effort!

About create_field_map, it should be optional. Maybe there's something I missed. I'll look into it

About your test, could you maybe move it to example/test_driver & add a test that performs a query?
Such as collection.whereMyEnum(isEqualTo: MyEnum.value) & maybe one for List too (although I think we're lacking arrayContains query for that.
There should be a few tests there that already do that which you could copy-paste

The goal would be to test that the generated work actually works, instead of simply compiling.

… pr/mrorabau/8386

rrousselGit · 2022-11-09T15:29:10Z

It sounds like we'll have to wait for Flutter to be compatible with analyzer 5.2.0 (which json_serializable uses).

… pr/mrorabau/8386

rrousselGit · 2022-11-28T10:27:22Z

It sounds like Flutter is now compatible with analyzer 5.2.0, so I'll resume fixing this :)

rrousselGit · 2022-11-28T12:33:30Z

Seems like I got confused. test wasn't updated on stable in the end. I guess it'll have to wait more or use master

mrorabau · 2022-12-11T16:11:23Z

Seems like I got confused. test wasn't updated on stable in the end. I guess it'll have to wait more or use master

@rrousselGit can you elaborate on this? I think you are saying the fix/compatability in the latest flutter isn't actually working on wasn't combined to master/stable?

gmarizy · 2023-01-26T22:18:20Z

@rrousselGit is Flutter/analyser v5.2+ compatibility issue solved with Flutter 3.7 ?

# Conflicts: # .github/workflows/firebase_firestore.yaml # .github/workflows/firebase_performance.yaml # melos.yaml # packages/cloud_firestore_odm/cloud_firestore_odm/example/pubspec.yaml # packages/cloud_firestore_odm/cloud_firestore_odm_generator/lib/src/collection_data.dart # packages/cloud_firestore_odm/cloud_firestore_odm_generator/pubspec.yaml # packages/cloud_firestore_odm/cloud_firestore_odm_generator/pubspec_overrides.yaml

Lyokone · 2024-03-19T14:28:50Z

Closing this PR, since the ODM is now hosted in its own repository: https://github.com/firebaseextended/firestoreodm-flutter

mrorabau changed the title ~~fix[odm_generator]: Add support for searching Enums~~ fix: [odm_generator]: Add support for searching Enums Apr 3, 2022

Salakar requested a review from rrousselGit April 4, 2022 12:10

russellwheatley added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Apr 21, 2022

google-oss-bot added the Stale Issue with no recent activity label Apr 22, 2022

google-oss-bot added Needs Attention This issue needs maintainer attention. and removed Stale Issue with no recent activity blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Apr 28, 2022

Salakar changed the title ~~fix: [odm_generator]: Add support for searching Enums~~ fix(odm): add support for searching Enums May 16, 2022

mrorabau requested review from lesnitsky, Salakar, kroikie and Ehesp as code owners May 25, 2022 19:12

ryanawhelan force-pushed the master branch from fc9d387 to e9e1c1b Compare July 8, 2022 01:29

russellwheatley added the plugin: odm label Jul 11, 2022

russellwheatley changed the title ~~fix(odm): add support for searching Enums~~ fix(cloud_firestore_odm): add support for searching Enums Jul 11, 2022

rrousselGit reviewed Jul 13, 2022

View reviewed changes

rrousselGit added 11 commits November 7, 2022 12:29

Fix warnings and ugrade analyzer

f40ccc6

Fix lints

cad8409

Use unreleased json_serializable

3764922

Add missing import

5388d21

Revert document_reference

e96417e

Use perfieldToJson

5f734e3

Merge branch 'master' of https://github.com/firebase/flutterfire into…

71f10d9

… pr/mrorabau/8386

Use git json_serializable

3abc71d

Revert gitignore

933e9df

Update where method

de6228d

handle orderBy offet operators

3edf38b

rrousselGit added 2 commits November 28, 2022 11:08

Merge branch 'master' of https://github.com/firebase/flutterfire into…

d571dd2

… pr/mrorabau/8386

Update generated files

3f7165e

rrousselGit closed this Nov 28, 2022

rrousselGit force-pushed the master branch from 3edf38b to 26087bb Compare November 28, 2022 12:14

rrousselGit reopened this Nov 28, 2022

rrousselGit added 5 commits November 28, 2022 13:42

Use flutter master channel

beb2b8a

Fix compilation error

be65adb

Update generated files

8591596

fix integration folder

f4f0bdc

Update generated files

d8adcb5

Lyokone closed this Mar 19, 2024

firebase locked and limited conversation to collaborators Apr 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cloud_firestore_odm): add support for searching Enums #8386

fix(cloud_firestore_odm): add support for searching Enums #8386

mrorabau commented Apr 3, 2022 •

edited

google-cla bot commented Apr 3, 2022

rrousselGit commented Apr 4, 2022 •

edited

mrorabau commented Apr 6, 2022

google-oss-bot commented Apr 22, 2022

mrorabau commented Apr 28, 2022

mrorabau commented May 15, 2022

mrorabau commented May 16, 2022

russellwheatley commented May 18, 2022

mrorabau commented May 18, 2022

mrorabau commented May 23, 2022

mrorabau commented Jul 8, 2022

rrousselGit commented Jul 9, 2022

rrousselGit commented Jul 12, 2022

mrorabau commented Jul 13, 2022 via email

rrousselGit Jul 13, 2022

mrorabau Jul 19, 2022

rrousselGit Jul 19, 2022

rrousselGit commented Nov 9, 2022

rrousselGit commented Nov 28, 2022

rrousselGit commented Nov 28, 2022 •

edited

mrorabau commented Dec 11, 2022

gmarizy commented Jan 26, 2023

Lyokone commented Mar 19, 2024

fix(cloud_firestore_odm): add support for searching Enums #8386

fix(cloud_firestore_odm): add support for searching Enums #8386

Conversation

mrorabau commented Apr 3, 2022 • edited

Description

Related Issues

Checklist

Breaking Change

google-cla bot commented Apr 3, 2022

rrousselGit commented Apr 4, 2022 • edited

mrorabau commented Apr 6, 2022

google-oss-bot commented Apr 22, 2022

mrorabau commented Apr 28, 2022

mrorabau commented May 15, 2022

mrorabau commented May 16, 2022

russellwheatley commented May 18, 2022

mrorabau commented May 18, 2022

mrorabau commented May 23, 2022

mrorabau commented Jul 8, 2022

rrousselGit commented Jul 9, 2022

rrousselGit commented Jul 12, 2022

mrorabau commented Jul 13, 2022 via email

rrousselGit Jul 13, 2022

Choose a reason for hiding this comment

mrorabau Jul 19, 2022

Choose a reason for hiding this comment

rrousselGit Jul 19, 2022

Choose a reason for hiding this comment

rrousselGit commented Nov 9, 2022

rrousselGit commented Nov 28, 2022

rrousselGit commented Nov 28, 2022 • edited

mrorabau commented Dec 11, 2022

gmarizy commented Jan 26, 2023

Lyokone commented Mar 19, 2024

mrorabau commented Apr 3, 2022 •

edited

rrousselGit commented Apr 4, 2022 •

edited

rrousselGit commented Nov 28, 2022 •

edited