Change default database name to postgres.
#7164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This DB name is always present in most Postgres setups.
|
Converting to draft pending internal discussion |
fredzqm
reviewed
May 10, 2024
| @@ -113,7 +113,7 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> { | |||
| cloudSqlDatabase = await promptOnce({ | |||
| message: `What ID would you like to use for your new database in ${cloudSqlInstanceId}?`, | |||
| type: "input", | |||
| default: `dataconnect`, | |||
| default: `postgres`, | |||
There was a problem hiding this comment.
Is the goal to improve database in emulator?
This changes the prod Cloud SQL database name, which I think a separate name it more clear.
I agree that we should make the local emulator url as default as possible.
There was a problem hiding this comment.
Let's continue the internal discussion on b/339903547 please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DB name is always present in most Postgres setups.