Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backends:delete improvements #7059

Merged
merged 8 commits into from Apr 29, 2024
Merged

backends:delete improvements #7059

merged 8 commits into from Apr 29, 2024

Conversation

tonyjhuang
Copy link
Contributor

This PR does two things:

  • Adds a spinner when waiting for the DeleteBackend LRO to complete
  • Adds logic to limit the location picker to only locations applicable to the backend id and skips the picker entirely if the backend id is not ambiguous

@tonyjhuang tonyjhuang requested a review from mathu97 April 27, 2024 04:11
@tonyjhuang tonyjhuang enabled auto-merge (squash) April 29, 2024 15:12
@tonyjhuang tonyjhuang merged commit 540aaab into master Apr 29, 2024
35 checks passed
@tonyjhuang tonyjhuang deleted the tonyjhuang/delete branch April 29, 2024 19:22
blidd-google pushed a commit that referenced this pull request May 1, 2024
@tonyjhuang @blidd-google
backends:delete improvements (#7059)
21e1d36 
* delete

* pass message

* tests
mathu97 pushed a commit that referenced this pull request May 6, 2024
@tonyjhuang @mathu97
backends:delete improvements (#7059)
4be9207 
* delete

* pass message

* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathu97 mathu97 mathu97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tonyjhuang @mathu97