add frameworks tests to windows job #7032
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
3 times, most recently
from
9e1a0c5
to
d4889d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7032 +/- ##
==========================================
+ Coverage 54.79% 54.84% +0.05%
==========================================
Files 359 361 +2
Lines 25110 25223 +113
Branches 5176 5202 +26
==========================================
+ Hits 13758 13834 +76
- Misses 10114 10145 +31
- Partials 1238 1244 +6 ☔ View full report in Codecov by Sentry. |
leoortizz
changed the title
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
from
f530050
to
a8ab026
Compare
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
from
a8ab026
to
e7785c0
Compare
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
from
a34adad
to
d133abf
Compare
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
from
d133abf
to
c922e0d
Compare
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
from
c4d2992
to
409753c
Compare
leoortizz
force-pushed
the
leoortizz_frameworksCi
branch
from
409753c
to
e57c355
Compare
leoortizz
changed the title
leoortizz
commented
May 1, 2024
| expect(apiStaticResponse.headers.get("custom-header")).to.eql("custom-value"); | ||
| expect(await apiStaticResponse.json()).to.eql(apiStaticJSON); | ||
|
|
||
| // TODO(leoortizz|jamesdaniels): Figure out why custmo headeres aren't wokring with emulators in Windows |
There was a problem hiding this comment.
@jamesdaniels I couldn't figure out why but the headers are incorrect when running with the emulators on Windows. content-type is false and custom-header is null
avoid confusion with Node.js `path.sep`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add frameworks tests on windows to CI. Mainly fix paths to work on Windows.
Scenarios Tested
Sample Commands