Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action-hosting-deploy version #7025

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

178inaba
Copy link

@178inaba 178inaba commented Apr 21, 2024

Description

FirebaseExtended/action-hosting-deploy runtime has been upgraded to node201.
Since it has not been released, we have modified it to specify the version using a hash value2.

Scenarios Tested

I tested it manually.
I used the official documentation for the steps.
https://firebase.google.com/docs/hosting/github-integration

Sample Commands

There are no command or flag changes.

Footnotes

  1. https://github.com/FirebaseExtended/action-hosting-deploy/commit/ac8041b3b04337509168113bf98b95879df22322

  2. https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-a-commits-sha-for-release-management

@178inaba 178inaba marked this pull request as ready for review April 21, 2024 17:02
@178inaba 178inaba force-pushed the fix-action-hosting-deploy-version branch 2 times, most recently from 0e8b8b6 to 984eceb Compare April 24, 2024 19:45
@178inaba 178inaba force-pushed the fix-action-hosting-deploy-version branch from 984eceb to 0732878 Compare May 3, 2024 14:17
@oyvindwe
Copy link

oyvindwe commented May 8, 2024

This is a poor solution, and not forward compatible. Could we please get a release of the GitHub action instead?

@178inaba
Copy link
Author

178inaba commented May 8, 2024

@oyvindwe
I am not authorized to release FirebaseExtended/action-hosting-deploy.

I also hope that a release will take place.
Because it can be fixed in @v1 once released.
However, the release seems to be delayed.
Therefore, I temporarily fixed it in this way to avoid the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants