Improve getting started experience #7011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
force-pushed
the
inlined.await-tls
branch
from
28bcf75
to
a635339
Compare
|
Reduced scope to just awaiting TLS now that other changes have been implemented. Changed the rollout text a bit since we may to continue waiting for TLS. Also, I removed a "..." because it seems redundant/passive aggressive along with a spinner. |
tonyjhuang
approved these changes
May 3, 2024
src/apphosting/index.ts
Outdated
| @@ -121,6 +148,7 @@ export async function doSetup( | |||
| }); | |||
|
|
|||
| await setDefaultTrafficPolicy(projectId, location, backendId, branch); | |||
| logSuccess(`Successfully created backend:\n\t${backend.name}`); | |||
There was a problem hiding this comment.
Remove, this is already on L138
There was a problem hiding this comment.
ugh. merge issues. I had previously moved and now it got turned into an add. TY for the catch.
src/apphosting/index.ts
Outdated
| createRolloutSpinner.succeed(`Your backend is now deployed at:\n\thttps://${backend.uri}`); | ||
| createRolloutSpinner.succeed("Rollout complete"); | ||
| if (!(await tlsReady(url))) { | ||
| const tlsSpinner = ora("Waiting for TLS certificate"); |
There was a problem hiding this comment.
you probably want tlsSpinner = ora(...).start()
There was a problem hiding this comment.
Whoops! Maybe Ora isn't as easy to use as I thought!
src/apphosting/index.ts
Outdated
| const createRolloutSpinner = ora( | ||
| "Starting a new rollout... This make take a few minutes. It's safe to exit now.", | ||
| "Starting a new rollout; this make take a few minutes. It's safe to exit now.", |
src/apphosting/index.ts
Outdated
| createRolloutSpinner.succeed(`Your backend is now deployed at:\n\thttps://${backend.uri}`); | ||
| createRolloutSpinner.succeed("Rollout complete"); | ||
| if (!(await tlsReady(url))) { | ||
| const tlsSpinner = ora("Waiting for TLS certificate"); |
There was a problem hiding this comment.
"Finalizing your backend's TLS certificate; this may take a few minutes."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about some of the prose I've moved about. Feel encouraged to nitpick and/or add other nitpickers as reviewers.