Remove distinction between build and run accounts #6952
+60
−213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjhuang
approved these changes
Apr 3, 2024
| metadata.push({ | ||
| location, | ||
| id, | ||
| serviceAccounts: serviceAccountsForBackend(projectNumber, backend), |
There was a problem hiding this comment.
is updating this field to be a Set an option?
| return target.serviceAccounts.length === test.serviceAccounts.length && target.serviceAccounts.every(sa => test.serviceAccounts.indexOf(sa) != -1); | ||
| return ( | ||
| target.serviceAccounts.length === test.serviceAccounts.length && | ||
| target.serviceAccounts.every((sa) => test.serviceAccounts.indexOf(sa) !== -1) |
There was a problem hiding this comment.
Having BackendMetadata.serviceAccounts be a Set could help making equality checks a little more straightforward. Otherwise, we end up with an order-dependent equality check which may be unexpected
tonyjhuang
requested changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luckily the distinction was easier to remove than to write!