Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where emulator didn't consider .env.local when discovering triggers. #5477

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Jan 31, 2023

Fixes #5219.

Note that the actual fix is a one-liner. I'm adding basic integration test for dotenv and params support for the emulator.

@taeold
Copy link
Contributor Author

taeold commented Jan 31, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 56.24% // Head: 56.24% // No change to project coverage 👍

Coverage data is based on head (d51114e) compared to base (978a10f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5477   +/-   ##
=======================================
  Coverage   56.24%   56.24%           
=======================================
  Files         317      317           
  Lines       21409    21409           
  Branches     4366     4366           
=======================================
  Hits        12042    12042           
  Misses       8318     8318           
  Partials     1049     1049           
Impacted Files Coverage Δ
src/emulator/functionsEmulator.ts 8.09% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taeold taeold merged commit 4408aeb into master Jan 31, 2023
@taeold taeold deleted the param-emu-local branch January 31, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase emulators:start always ignores .env file and throws “Attempted to write param-defined key” error
3 participants