Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump storage rules emulator version #5342

Merged
merged 5 commits into from Dec 16, 2022
+6 −5
Merged

Bump storage rules emulator version #5342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07b6e49
Bump storage rules emulator version; correct null_value field accordi…
sam-gc Dec 15, 2022
170f660
Update changelog
sam-gc Dec 15, 2022
d44fe71
Merge branch 'master' into sam-gc/storage-emu-bump
sam-gc Dec 15, 2022
6c0827b
Merge branch 'master' into sam-gc/storage-emu-bump
sam-gc Dec 16, 2022
90b4d24
Format
sam-gc Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -6,3 +6,4 @@
- Log the reason for a Cloud Function if needed in Next.js (#5320)
- Fixed service enablement when installing extensions with v2 functions (#5338)
- Fix bug where functions:shell command didn't connect to emulators running on other processes. (#5269)
- Fixed bug with Cross-Service Rules integration for Firestore documents containing nulls (#5342)
6 changes: 3 additions & 3 deletions src/emulator/downloadableEmulators.ts
View file
Open in desktop
Expand Up @@ -38,9 +38,9 @@ const EMULATOR_UPDATE_DETAILS: { [s in DownloadableEmulators]: EmulatorUpdateDet
expectedChecksum: "4f41d24a3c0f3b55ea22804a424cc0ee",
},
storage: {
version: "1.1.1",
expectedSize: 46448285,
expectedChecksum: "691982db4019d49d345a97151bdea7e2",
version: "1.1.2",
expectedSize: 47028740,
expectedChecksum: "983b4415b1e72b109864f1b8e7ea7546",
},
ui: experiments.isEnabled("emulatoruisnapshot")
? { version: "SNAPSHOT", expectedSize: -1, expectedChecksum: "" }
Expand Down
4 changes: 2 additions & 2 deletions src/emulator/storage/rules/runtime.ts
View file
Open in desktop
Expand Up @@ -415,7 +415,7 @@ function toExpressionValue(obj: any): ExpressionValue {

if (obj == null) {
return {
null_value: 0,
null_value: null,
};
}

Expand Down Expand Up @@ -484,7 +484,7 @@ function createRequestExpressionValue(opts: RulesetVerificationOpts): Expression
},
time: toExpressionValue(new Date()),
resource: toExpressionValue(opts.file.after ? opts.file.after : null),
auth: opts.token ? createAuthExpressionValue(opts) : { null_value: 0 },
auth: opts.token ? createAuthExpressionValue(opts) : { null_value: null },
};

return {
Expand Down