Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paths that have middleware (Next.js) should route through Cloud Functions #5320

Merged
merged 56 commits into from Dec 13, 2022
Merged

Paths that have middleware (Next.js) should route through Cloud Functions #5320

merged 56 commits into from Dec 13, 2022

Commits on Oct 31, 2022

  1. Skip middleware deploy to hosting

    @jamesdaniels
    jamesdaniels committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    0936933 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. use host/port from hosting emulator in dev server

    @leoortizz
    leoortizz committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    ee5d836 View commit details
    Browse the repository at this point in the history

  2. add TODO to serve

    @leoortizz
    leoortizz committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    c53dc89 View commit details
    Browse the repository at this point in the history

  3. hostingEmulatorData > hostingEmulatorInfo

    @leoortizz
    leoortizz committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    dae6acd View commit details
    Browse the repository at this point in the history

  4. prettier fixes

    @leoortizz
    leoortizz committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    8f11137 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Merge branch 'master' into leoortizz_next_miss_host_and_port

    @leoortizz
    leoortizz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    0e17f9c View commit details
    Browse the repository at this point in the history

  2. use types directly in getDevModeHandle parameters

    @leoortizz
    leoortizz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4616a41 View commit details
    Browse the repository at this point in the history

  3. add TODO to reuse getDevModeHandle types

    @leoortizz
    leoortizz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    cfae0d5 View commit details
    Browse the repository at this point in the history

  4. remove unused type

    @leoortizz
    leoortizz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    4f7a45f View commit details
    Browse the repository at this point in the history

  5. hardcode hosting emulator info in serve

    @leoortizz
    leoortizz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    56f498f View commit details
    Browse the repository at this point in the history

  6. changelog

    @leoortizz
    leoortizz committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    6d89d2c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. prettier in changelog

    @leoortizz
    leoortizz committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    5c64a72 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into leoortizz_next_miss_host_and_port

    @leoortizz
    leoortizz committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4e661e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Missing import

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    79c99df View commit details
    Browse the repository at this point in the history

  2. Merge master

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    f3a5102 View commit details
    Browse the repository at this point in the history

  3. Drop next export & simplify

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    53eb470 View commit details
    Browse the repository at this point in the history

  4. Adding reasons, formatting

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    b581ef4 View commit details
    Browse the repository at this point in the history

  5. Changelog

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    a7a0af5 View commit details
    Browse the repository at this point in the history

  6. Add host and port to Next custom server (dev-mode) for middleware fir… 

    …ebase#5201
    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ee25526 View commit details
    Browse the repository at this point in the history

  7. Middleware just wont work in serve

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    41a0c70 View commit details
    Browse the repository at this point in the history

  8. TODO

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    61d8599 View commit details
    Browse the repository at this point in the history

  9. Drop unused vars

    @jamesdaniels
    jamesdaniels committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    0a7b583 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Merge master

    @jamesdaniels
    jamesdaniels committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    59fe5bc View commit details
    Browse the repository at this point in the history

  2. Remove stray char

    @jamesdaniels
    jamesdaniels committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    509e28c View commit details
    Browse the repository at this point in the history

  3. readJSON generics

    @jamesdaniels
    jamesdaniels committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b3e1550 View commit details
    Browse the repository at this point in the history

  4. Cleanup

    @jamesdaniels
    jamesdaniels committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9f30d6f View commit details
    Browse the repository at this point in the history

  5. Messaging, quotes, and we still need to check the rewrites to use

    @jamesdaniels
    jamesdaniels committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4a36e29 View commit details
    Browse the repository at this point in the history

  6. Fix tests

    @jamesdaniels
    jamesdaniels committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    bc421df View commit details
    Browse the repository at this point in the history

  7. use manifests filenames from next/constants

    @leoortizz
    leoortizz committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    4489406 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. isUsingMiddleware

    @leoortizz
    leoortizz committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b60a4bf View commit details
    Browse the repository at this point in the history

  2. throw error if using middleware with serve

    @leoortizz
    leoortizz committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    570a748 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into leoortizz_skip_midd… 

    …leware_matches
    @leoortizz
    leoortizz committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    3c576de View commit details
    Browse the repository at this point in the history

  4. remove unused CLI_COMMAND

    @leoortizz
    leoortizz committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    4df08ee View commit details
    Browse the repository at this point in the history

  5. public dir as constant

    @leoortizz
    leoortizz committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    cf3ffe3 View commit details
    Browse the repository at this point in the history

  6. more readJSON generics

    @leoortizz
    leoortizz committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    7bf769e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. use next constants as types

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    c7658a4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into leoortizz_skip_middleware_matches

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    647410c View commit details
    Browse the repository at this point in the history

  3. read manifest in isUsingMiddleware, handle dev/prod

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    00d152b View commit details
    Browse the repository at this point in the history

  4. more constants

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    49aa52c View commit details
    Browse the repository at this point in the history

  5. isUsingMiddleware tests

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    59a2ca5 View commit details
    Browse the repository at this point in the history

  6. isUsingImageOptimization

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fe5526c View commit details
    Browse the repository at this point in the history

  7. ImageManifest > ImagesManifest

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    10de8b5 View commit details
    Browse the repository at this point in the history

  8. isUsingImageOptimization tests

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0a970a9 View commit details
    Browse the repository at this point in the history

  9. move testing variables to helpers/images

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4561b4b View commit details
    Browse the repository at this point in the history

  10. helpers/middleware

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    676c88b View commit details
    Browse the repository at this point in the history

  11. mock actual readJSON being used, onCall > withArgs

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    22d60f1 View commit details
    Browse the repository at this point in the history

  12. more stub fixes in isUsingImageOptimization

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7754e9c View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into leoortizz_skip_middleware_matches

    @jamesdaniels
    jamesdaniels committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8c4e058 View commit details
    Browse the repository at this point in the history

  14. fix isUsingMiddleware manifest path for production

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e51a0a6 View commit details
    Browse the repository at this point in the history

  15. prevent lint error in WIP function

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    cc14284 View commit details
    Browse the repository at this point in the history

  16. pass missing distDir, fix doc

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    2147c89 View commit details
    Browse the repository at this point in the history

  17. isUsingAppDirectory checking only manifest existence

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4a48f2f View commit details
    Browse the repository at this point in the history

  18. isUsingAppDirectory unit tests

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0344bcd View commit details
    Browse the repository at this point in the history

  19. Merge branch 'master' into leoortizz_skip_middleware_matches

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    90a1c5b View commit details
    Browse the repository at this point in the history

  20. changelog

    @leoortizz
    leoortizz committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5a545a5 View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' into leoortizz_skip_middleware_matches

    @jamesdaniels
    jamesdaniels committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    23b55da View commit details
    Browse the repository at this point in the history