Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/next js predeploy hooks #5288

Merged
merged 7 commits into from Dec 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -3,4 +3,5 @@
- Fix bug in auth emulator in which createdAt was not set for signInWithIdp new users. (#5203)
- Default to --no-localhost when calling login from Google Cloud Workstations
- Support the x-goog-api-key header in auth emulator. (#5249)
- Fix bug in deploying web frameworks when a predeploy hook was configured in firebase.json (#5199)
- Fix bug where function deployments using --only filter sometimes failed deployments. (#5280)
2 changes: 1 addition & 1 deletion src/deploy/lifecycleHooks.ts
Expand Up @@ -48,7 +48,7 @@ function getChildEnvironment(target: string, overallOptions: any, config: any) {
let resourceDir;
switch (target) {
case "hosting":
resourceDir = overallOptions.config.path(config.public);
resourceDir = overallOptions.config.path(config.public ?? config.source);
break;
case "functions":
resourceDir = overallOptions.config.path(config.source);
Expand Down