Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect Google Cloud Workstations #5283

Merged
merged 4 commits into from Dec 1, 2022
Merged

Detect Google Cloud Workstations #5283

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b66f41
Detect Google Cloud Workstations
jamesdaniels Dec 1, 2022
09c1033
Formatting
jamesdaniels Dec 1, 2022
4cce6a1
Add tests
jamesdaniels Dec 1, 2022
02a53c0
Merge branch 'master' into jamesdaniels_workstationsDetection
jamesdaniels Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,3 +1,4 @@
- Fix bug where disabling background triggers did nothing. (#5221)
- Fix bug in auth emulator where empty string should throw invalid email instead of missing email. (#3898)
- Fix bug in auth emulator in which createdAt was not set for signInWithIdp new users. (#5203)
- Default to --no-localhost when calling login from Google Cloud Workstations
2 changes: 1 addition & 1 deletion src/utils.ts
View file
Open in desktop
Expand Up @@ -577,7 +577,7 @@ export function datetimeString(d: Date): string {
* Indicates whether the end-user is running the CLI from a cloud-based environment.
*/
export function isCloudEnvironment() {
return !!process.env.CODESPACES;
return !!process.env.CODESPACES || !!process.env.GOOGLE_CLOUD_WORKSTATIONS;
}

/**
Expand Down