Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signInWithPassword error handling for empty string emails #5258

Merged
merged 1 commit into from Nov 17, 2022

Conversation

lisajian
Copy link
Contributor

@lisajian lisajian commented Nov 17, 2022

Description

Updates error handling for email cases. Reference for how the backend handles email validation: link.

Fixes #3898

Scenarios Tested

  • npm test passes
  • Verified against JSSDK Auth Demo App. See screenshot.

Sample Commands

N/A

@codecov-commenter
Copy link

Codecov Report

Base: 56.26% // Head: 56.27% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d7e1b69) compared to base (2354100).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5258   +/-   ##
=======================================
  Coverage   56.26%   56.27%           
=======================================
  Files         309      309           
  Lines       20818    20819    +1     
  Branches     4224     4224           
=======================================
+ Hits        11714    11715    +1     
  Misses       8092     8092           
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/auth/operations.ts 83.40% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lisajian lisajian enabled auto-merge (squash) November 17, 2022 23:43
@lisajian lisajian merged commit a71d911 into master Nov 17, 2022
@lisajian lisajian deleted the lj-invalidemail branch November 18, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signInWithEmailAndPassword method throws an incorrect error when Authentication emulator is enabled
4 participants