Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a bug where extensions emulator was not appearing in the registry #5242

Merged
merged 2 commits into from Nov 15, 2022
Merged

Fixes a bug where extensions emulator was not appearing in the registry #5242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03e242
Fixes a bug where extensions emualtor was not appearing in the registry
joehan Nov 15, 2022
6d2a8af
changelog
joehan Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Expand Up @@ -3,4 +3,5 @@
- Fixes gzipped file handling in Storage Emulator.
- Add support for object list using certain Admin SDKs (#5208)
- Fixes source token expiration issue by acquiring new source token upon expiration.
- Fix bug where emulated event triggered function broke in debug mode (#5211)
- Fixes bug where emulated event triggered function broke in debug mode (#5211)
- Fixes bug that caused the Extensions Emulator to always appear to be inactive in the Emulator UI.
2 changes: 1 addition & 1 deletion src/emulator/extensionsEmulator.ts
View file
Open in desktop
Expand Up @@ -67,7 +67,7 @@ export class ExtensionsEmulator implements EmulatorInstance {
"Extensions Emulator is running but Functions emulator is not. This should never happen."
);
}
return functionsEmulator.getInfo();
return { ...functionsEmulator.getInfo(), name: this.getName() };
}

public getName(): Emulators {
Expand Down