Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next 13 fixes #5175
Next 13 fixes #5175
Changes from 12 commits
0e5a7e0
4db6cb6
578346a
1e8665d
7037376
de2a50b
b6a5ab9
6853f71
e0bdfc1
a4f5e41
8acb5a9
7bae042
f4be89c
c266bd6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be
of
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not an iterable, it's an object:
{ "/foo": { ... }, "/bar": { ... }}
so in is correct, though with the linting rule (to ensure we don't iterate over private) it's a little verbose... perhaps
const path of Object.keys(prerenderManifest)
orconst [path, route] of Object.entries(prerenderManifest.routes)
would be stylistically preferable?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
slice
andfilter
bits seem redundant. It seems like you're usingsplice(1)
because leading slashes will lead to an empty element from split (are we guaranteed to lead with a slash?) and filter will filter out empty components as well. So if you're only and always going to have a leading slash, then splice does the trick. But filter seems like it works for that case and a final slash.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was likely overly defensive here, worrying aboth leading/trailing slash, I'll check my assumptions. that said, we're pushing cleanURLs to be true by default now when paired with hosting.source, I can probably simplify this code. I'll do that in a follow on so I unblock Next 13 from working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took on as a TODO to explore simplifying