Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provisioning checks should be best effort #5163

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Provisioning checks should be best effort #5163

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de30776
Provisioning checks should be best effort
joehan Oct 24, 2022
c3689c8
Merge branch 'master' into jh-skip-provisoning
joehan Oct 24, 2022
7ef3037
Fixing import issue
joehan Oct 24, 2022
8353b53
merging
joehan Oct 24, 2022
6750de7
Merge branch 'master' into jh-skip-provisoning
joehan Oct 25, 2022
5b1f337
Merge branch 'master' into jh-skip-provisoning
joehan Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Release RTDB Emulator v4.11.0: Wire protocol update for `startAfter`, `endBefore`.
- Fixes an issue where an error during product provisioning check would block `firebase deploy --only extensions` (#5074).
- Releases RTDB Emulator v4.11.0: Wire protocol update for `startAfter`, `endBefore`.
17 changes: 11 additions & 6 deletions src/extensions/provisioningHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Client } from "../apiv2";
import { flattenArray } from "../functional";
import { FirebaseError } from "../error";
import { getExtensionSpec, InstanceSpec } from "../deploy/extensions/planner";
import { logger } from "../logger";

/** Product for which provisioning can be (or is) deferred */
export enum DeferredProduct {
Expand Down Expand Up @@ -55,12 +56,16 @@ async function checkProducts(projectId: string, usedProducts: DeferredProduct[])
if (usedProducts.includes(DeferredProduct.AUTH)) {
isAuthProvisionedPromise = isAuthProvisioned(projectId);
}

if (isStorageProvisionedPromise && !(await isStorageProvisionedPromise)) {
needProvisioning.push(DeferredProduct.STORAGE);
}
if (isAuthProvisionedPromise && !(await isAuthProvisionedPromise)) {
needProvisioning.push(DeferredProduct.AUTH);
try {
if (isStorageProvisionedPromise && !(await isStorageProvisionedPromise)) {
needProvisioning.push(DeferredProduct.STORAGE);
}
if (isAuthProvisionedPromise && !(await isAuthProvisionedPromise)) {
needProvisioning.push(DeferredProduct.AUTH);
}
} catch (err: any) {
// If a provisioning check throws, we should fail open since this is best effort.
logger.debug(`Error while checking product provisioning, failing open: ${err}`);
}

if (needProvisioning.length > 0) {
Expand Down