Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak default ints in text input #5118

Merged
merged 6 commits into from Oct 13, 2022
Merged

Unbreak default ints in text input #5118

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e10836
Unbreak default ints in text input
Berlioz Oct 12, 2022
2ed29c7
add a comment explaining this
Berlioz Oct 13, 2022
e6f1897
the ternary is not needed
Berlioz Oct 13, 2022
3757fba
Merge branch 'master' into fix_blank_fields
Berlioz Oct 13, 2022
a8710c7
add release note
Berlioz Oct 13, 2022
d36e8f5
format:other
Berlioz Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/deploy/functions/params.ts
View file
Open in desktop
Expand Up @@ -590,7 +590,7 @@ async function promptText<T extends RawParamValue>(
resolvedDefault: T | undefined,
converter: (res: string) => T | retryInput
): Promise<T> {
const res = await promptOnce({
const res: any = await promptOnce({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not typeof resolvedDefaut | string? Or just call resolvedDefautl.toString() in the prompt call?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to do the .toString() thing in this call because I wanted as small a footprint of a change in an emergency patch as possible; I'd agree that it'd probably be just as good/better.

The :any annotation is unnecessary with that tip you gave about string.toString() below, since all it's doing is reassuring tsc that it's not going to have to call never.toString() down below. I'm getting rid of it.

type: "input",
default: resolvedDefault,
message: prompt,
Expand All @@ -605,7 +605,7 @@ async function promptText<T extends RawParamValue>(
return promptText<T>(prompt, input, resolvedDefault, converter);
}
}
const converted = converter(res);
const converted = converter(typeof res === "string" ? res : res.toString());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun fact: string also implements toString so that you can avoid ternaries like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I knew that, but I apparently didn't know that.

if (typeof converted === "object") {
logger.error(converted.message);
return promptText<T>(prompt, input, resolvedDefault, converter);
Expand Down