Fix Functions emulator not starting for frameworks. #5090
Conversation
| @@ -324,29 +324,9 @@ export async function startAll( | |||
| } | |||
|
|
|||
| const emulatableBackends: EmulatableBackend[] = []; | |||
| const projectDir = (options.extDevDir || options.config.projectDir) as string; | |||
There was a problem hiding this comment.
This block has been moved back to where it was
Codecov ReportBase: 56.06% // Head: 56.19% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5090 +/- ##
==========================================
+ Coverage 56.06% 56.19% +0.13%
==========================================
Files 307 307
Lines 20635 20738 +103
Branches 4166 4201 +35
==========================================
+ Hits 11568 11654 +86
- Misses 8066 8084 +18
+ Partials 1001 1000 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yuchenshi
force-pushed
the
ys/late-assign
branch
from
c689d7d
to
69176ae
Compare
|
Any chance you can write some tests to reduce further regression opportunities? |
I have some ideas -- I think we need something like the existing emulator integration tests for the web frameworks in general, but that is a bigger ask. Happy to discuss more offline. |
Description
Fix regression introduced by #5083 where code block with side effects were moved.
Scenarios Tested
Started a project with no functions but with frameworks, and the Functions emulator now start correctly.
Sample Commands