Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Firestore WebSocket port in hub. Fixes #5051. #5081

Merged
merged 2 commits into from Oct 6, 2022

Conversation

yuchenshi
Copy link
Member

@yuchenshi yuchenshi commented Oct 6, 2022

Description

Fixes #5051
Fixes firebase/firebase-tools-ui#863

Scenarios Tested

Manually started the suite + UI, and tested on UI. The Requests tab no longer show errors and can display operations again.

Sample Commands

@yuchenshi yuchenshi enabled auto-merge (squash) October 6, 2022 21:59
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 55.76% // Head: 55.75% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (9f6a51c) compared to base (655f8e8).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5081      +/-   ##
==========================================
- Coverage   55.76%   55.75%   -0.01%     
==========================================
  Files         305      305              
  Lines       20522    20524       +2     
  Branches     4142     4144       +2     
==========================================
  Hits        11444    11444              
- Misses       8096     8098       +2     
  Partials      982      982              
Impacted Files Coverage Δ
src/emulator/firestoreEmulator.ts 22.22% <0.00%> (-0.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yuchenshi yuchenshi merged commit 1c0a218 into master Oct 6, 2022
@yuchenshi yuchenshi deleted the ys/fix-firestore-ws branch October 6, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants