Fix Hosting deploys #5077
Merged
Fix Hosting deploys #5077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
approved these changes
Oct 6, 2022
Codecov ReportBase: 55.75% // Head: 55.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5077 +/- ##
==========================================
- Coverage 55.75% 55.75% -0.01%
==========================================
Files 305 305
Lines 20513 20522 +9
Branches 4139 4142 +3
==========================================
+ Hits 11437 11442 +5
- Misses 8093 8097 +4
Partials 983 983
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
steveoh
reviewed
Oct 6, 2022
Comment on lines
+85
to
+87
| * TODO: this currently lists remote backends (functions) and attemtps to validate them. | ||
| * We currently catch 403 issues and handle them, but it's probably not the best solution | ||
| * to have a required permission in functions when a deploy may "only" be to Hosting. |
There was a problem hiding this comment.
suggestion: convert this to an issue
christhompsongoogle
pushed a commit
that referenced
this pull request
Oct 6, 2022
* fix path import * adds check for permission issues when resolving Hosting configs
|
Thanks @bkendall! Any ETA on the version release? I'm using the Firebase GH action, which has been broken since this morning. Though FirebaseExtended/action-hosting-deploy#242 could also be a solution. |
tamalsaha
added a commit
to appscode/blog
that referenced
this pull request
Oct 6, 2022
xref: firebase/firebase-tools#5077 Signed-off-by: Tamal Saha <tamal@appscode.com>
tamalsaha
added a commit
to appscode/blog
that referenced
this pull request
May 17, 2024
xref: firebase/firebase-tools#5077 Signed-off-by: Tamal Saha <tamal@appscode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TypeError: Cannot read properties of undefined (reading 'join')An import that was
import path from "path"wasn't working correctly.Error: HTTP Error: 403, Permission 'cloudfunctions.functions.list' denieddeploying HostingLogic was added to check for backends but no assertion was made that the callee would have permissions. Added a check to make sure that (1) we had rewrites we should try to resolve and (b) catch permissions issues and silence them.
Fixes #5071