New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Experiments feature #4994
Merged
Merged
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
269cf66
Checkpoint; wip
inlined edc5fb7
Add mandatory JSDocs
inlined fbc4800
Add missing file
inlined 7fb879d
Remove dead code
inlined a5cc083
Add experiments commands
inlined e51cc64
Add missing files
inlined 8de1c7f
Merge remote-tracking branch 'origin/master' into inlined.experiments
inlined e7445c0
Remove dead experiments
inlined 7038e3c
Update docuentation strings
inlined aa77661
Fix case of no previews config (new machines)
inlined 363dc93
Merge branch 'master' into inlined.experiments
inlined f19c209
PR feedback
inlined a069947
Fix type conversion issue
inlined 4984825
Merge + changes
inlined 8a461f8
Merge remote-tracking branch 'origin/master' into inlined.experiments
inlined 7808be8
PR feedback
inlined ede6af4
Merge remote-tracking branch 'origin/master' into inlined.experiments
inlined 05ac750
Fix linter error
inlined b0dfaa8
Merge branch 'master' into inlined.experiments
inlined File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ import { FirebaseError } from "../../error"; | |
import { configForCodebase, normalizeAndValidate } from "../../functions/projectConfig"; | ||
import { AUTH_BLOCKING_EVENTS } from "../../functions/events/v1"; | ||
import { generateServiceIdentity } from "../../gcp/serviceusage"; | ||
import { previews } from "../../previews"; | ||
import * as experiments from "../../experiments"; | ||
import { applyBackendHashToBackends } from "./cache/applyHash"; | ||
import { allEndpoints, Backend } from "./backend"; | ||
|
||
|
@@ -272,7 +272,7 @@ export async function prepare( | |
* This must be called after `await validate.secretsAreValid`. | ||
*/ | ||
updateEndpointTargetedStatus(wantBackends, context.filters || []); | ||
if (previews.skipdeployingnoopfunctions) { | ||
if (experiments.isEnabled("skipdeployingnoopfunctions")) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @TheIronDev When does this experiment go away? |
||
applyBackendHashToBackends(wantBackends, context); | ||
} | ||
} | ||
|
@@ -346,6 +346,9 @@ function maybeCopyTriggerRegion(wantE: backend.Endpoint, haveE: backend.Endpoint | |
wantE.eventTrigger.region = haveE.eventTrigger.region; | ||
} | ||
|
||
/** | ||
* Determines whether endpoints are targeted by an --only flag. | ||
*/ | ||
export function updateEndpointTargetedStatus( | ||
wantBackends: Record<string, Backend>, | ||
endpointFilters: EndpointFilter[] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Berlioz Does this still need to be hidden behind an experiment or do we think we are stable enough to roll forward? (If not, can we leave a comment on when this should be rolled forward?)