fix error messaging in apps:sdkconfig #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
reviewed
May 17, 2022
| // If there's only one, use it. | ||
| appId = apps[0].appId; | ||
| appPlatform = apps[0].platform; | ||
| } else if (options.nonInteractive) { |
There was a problem hiding this comment.
How does this behave when there are 0 apps? Do we show the correct error?
There was a problem hiding this comment.
Above, on L77, it checks for apps and will throw an error if there are no apps.
There was a problem hiding this comment.
Derp, just saw that you had a screenshot of this case. LGTM
joehan
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error messaging when trying to get apps:sdkconfig was confusing and inconsistent when in interactive vs. non-interactive mode. Unify the error messaging to make a bit more sense and to be consistent when there are no apps.
Fixes #4007
Scenarios Tested