Add typing to proto converters and fix breaks #4544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colerogers
reviewed
May 17, 2022
| "minBackoffSeconds", | ||
| (seconds) => proto.durationFromSeconds(resolveInt(seconds)) | ||
| ); | ||
| proto.renameIfPresent( |
There was a problem hiding this comment.
Isn't this identical to L374?
src/gcp/cloudfunctionsv2.ts
Outdated
| return bytes / (1 << 20); | ||
| bytes = bytes / (1 << 20); | ||
| const typed = bytes as backend.MemoryOptions; | ||
| if (backend.AllMemoryOptions.includes(typed)) { |
There was a problem hiding this comment.
should there be a ! here? like if typed is not in AllMemoryOptions then we'd throw a warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing #4543 I decided that I now know how to make
proto.renameIfPresentmore strongly typed and made a change that would have caught the error before it was ever a bug.Did that and started fixing the build breaks it caught. Since I noticed a lot of converter code for
buildwas using the same key name, I also addedproto.convertIfPresent.The build code was broken for scheduled functions. That's because the old
triggerParseruses durations whereas the container contract uses seconds (so we can use number params). The code looks extra wonky becausebackend.Backendalso uses durations. As an exercise for the reader, someone should probably makebackend.Backenduse seconds and convert to/from duration inendpointFromFunctionandfunctionFromEndpoint. duration is silly and should be in as little of our type system as possible.