Correctly copy over secret environment variables

CHANGELOG.md

@@ -0,0 +1 @@
+- Fixes bug where secret environment variables were not set on functions (#4543)

src/deploy/functions/runtimes/discovery/v1alpha1.ts

@@ -250,16 +250,15 @@ function parseEndpoints(
       "secretEnvironmentVariables",
       "secretEnvironmentVariables",
       (senvs: ManifestEndpoint["secretEnvironmentVariables"]) => {
-        if (senvs && senvs.length > 0) {
-          ep.secretEnvironmentVariables = [];
-          for (const { key, secret } of senvs) {
-            ep.secretEnvironmentVariables.push({
-              key,
-              secret: secret || key, // if secret is undefined, assume env var key == secret name
-              projectId: project,
-            });
-          }
+        const secretEnvironmentVariables: backend.SecretEnvVar[] = [];
+        for (const { key, secret } of senvs!) {
+          secretEnvironmentVariables.push({
+            key,
+            secret: secret || key, // if secret is undefined, assume env var key == secret name
+            projectId: project,
+          });
         }
+        return secretEnvironmentVariables;
       }
     );
     allParsed.push(parsed);