replace single usage of enable with ensure #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
requested changes
Dec 9, 2021
| @@ -22,8 +22,8 @@ module.exports = async function (setup: any, config: any, options: Options) { | |||
| if (projectId) { | |||
| await requirePermissions({ ...options, project: projectId }); | |||
| await Promise.all([ | |||
| ensureApiEnabled.enable(projectId, "cloudfunctions.googleapis.com"), | |||
| ensureApiEnabled.enable(projectId, "runtimeconfig.googleapis.com"), | |||
| ensure(projectId, "cloudfunctions.googleapis.com", "unused", true), | |||
There was a problem hiding this comment.
Why did you add these last 2 args? Doesn't seem like they should be here.
There was a problem hiding this comment.
At least the 3rd is required. It's "label" (for printing messages) and "silent" (again, printing messages). Setting them to have the same behavior as it does today.
joehan
approved these changes
Dec 10, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* replace single usage of enable with ensure * add comment to enable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Permissions for checking if an API is enabled and actually enabling the API are separate. Some users may have the former, not the latter. So, let's stick to using only
ensureso that those users can succeed.I went ahead and un-exported
enableto make it harder to use it outside its file (and added a comment in code).Fixes #2574.
Scenarios Tested
init'd functions. also did it turning off the API to make sure it was re-enabled.