Bucket filtering in the functions emulator #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly fixed the tests
taeold
approved these changes
Nov 25, 2021
| expect(test.storageBucketV2MetadataTriggerCount).to.equal(1); | ||
| expect(test.storageBucketDeletedTriggerCount).to.equal(0); | ||
| expect(test.storageBucketV2DeletedTriggerCount).to.equal(0); | ||
| test.resetCounts(); |
There was a problem hiding this comment.
aside* I'd like to see this function be called in afterEach hook, but I see that this isn't possible due to the way the test cases are structured today :/.
|
Love the comprehensive tests, looks good to me. |
abeisgoat
approved these changes
Dec 8, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* added filtering * change to use headers * using data attribute instead of header & adding integration tests * adding default-bucket into tests * local testing keeps failing, trying again on github workflows.... * removed 'default-bucket', added reset counter to framework, and finally fixed the tests * add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature change to add bucket filtering to the functions emulator from storage events. Checks if
proto.data.bucketexists in the multicast handler and appends additional content to the trigger key. This change includes a set of trigger integration tests.