Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for Auth Emulator IDP widget. #3774

Merged
merged 2 commits into from Sep 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
@@ -1,2 +1,3 @@
- `ext:dev:publish` and `ext:update` now support --force and --non-interactive flags.
- Fixes issue where account specified by `login:use` was not being correctly loaded (#3759).
- Fixes minor layout issues in Auth Emulator IDP sign-in page (#3774).
6 changes: 4 additions & 2 deletions src/emulator/auth/handlers.ts
Expand Up @@ -195,9 +195,11 @@ export function registerHandlers(
<span class="mdc-list-item__graphic material-icons" aria-hidden=true>person</span>`
}
<span class="mdc-list-item__text"><span class="mdc-list-item__primary-text">${
info.displayName
info.displayName || "(No display name)"
}</span>
<span class="mdc-list-item__secondary-text fallback-secondary-text">${
info.email || ""
}</span>
<span class="mdc-list-item__secondary-text fallback-secondary-text">${info.email}</span>
</li>`
)
.join("\n");
Expand Down
4 changes: 2 additions & 2 deletions src/emulator/auth/widget_ui.ts
Expand Up @@ -491,7 +491,7 @@ export const WIDGET_UI = `
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Auth Emulator IDP Login Widget</title>
<link href="https://unpkg.com/material-components-web@latest/dist/material-components-web.min.css" rel="stylesheet">
<link href="https://unpkg.com/material-components-web@10/dist/material-components-web.min.css" rel="stylesheet">
<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;500&display=swap" rel="stylesheet">
<style>${STYLE}</style>
Expand Down Expand Up @@ -604,6 +604,6 @@ export const WIDGET_UI = `
</div>
</div>
</div>
<script src="https://unpkg.com/material-components-web@latest/dist/material-components-web.min.js"></script>
<script src="https://unpkg.com/material-components-web@10/dist/material-components-web.min.js"></script>
<script>${SCRIPT}</script>
`;