Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix login:use and account resolution issue #3773

Merged
merged 2 commits into from Sep 22, 2021
Merged

fix login:use and account resolution issue #3773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e3125d
fix login:use and account resolution issue
bkendall Sep 22, 2021
e6b3830
Merge branch 'master' of github.com:firebase/firebase-tools into bk-3759
bkendall Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1 +1,2 @@
- `ext:dev:publish` and `ext:update` now support --force and --non-interactive flags.
- Fixes issue where account specified by `login:use` was not being correctly loaded (#3759).
4 changes: 3 additions & 1 deletion src/command.ts
View file
Open in desktop
Expand Up @@ -260,14 +260,16 @@ export class Command {
const account = getInheritedOption(options, "account");
options.account = account;

// selectAccount needs the projectRoot to be set.
options.projectRoot = detectProjectRoot(options);

const projectRoot = options.projectRoot;
const activeAccount = selectAccount(account, projectRoot);

if (activeAccount) {
setActiveAccount(options, activeAccount);
}

options.projectRoot = detectProjectRoot(options);
this.applyRC(options);
if (options.project) {
await this.resolveProjectIdentifiers(options);
Expand Down