Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump storage rules emulator version #5342

Merged
merged 5 commits into from Dec 16, 2022
Merged

Bump storage rules emulator version #5342

merged 5 commits into from Dec 16, 2022

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Dec 15, 2022

Also update null_value evaluation accordingly.

Fixes #5251

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Base: 56.43% // Head: 56.43% // No change to project coverage 👍

Coverage data is based on head (07b6e49) compared to base (2a25c5f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5342   +/-   ##
=======================================
  Coverage   56.43%   56.43%           
=======================================
  Files         315      315           
  Lines       21137    21137           
  Branches     4290     4290           
=======================================
  Hits        11928    11928           
  Misses       8184     8184           
  Partials     1025     1025           
Impacted Files Coverage Δ
src/emulator/downloadableEmulators.ts 23.88% <ø> (ø)
src/emulator/storage/rules/runtime.ts 11.37% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry for this.

@sam-gc
Copy link
Contributor Author

sam-gc commented Dec 15, 2022

Done

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to rerun the linter, but LGTM otherwise.

@sam-gc sam-gc merged commit 77e6e6d into master Dec 16, 2022
@sam-gc sam-gc deleted the sam-gc/storage-emu-bump branch December 16, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EvaluationException when using crosss-service security rule with Emulator
4 participants