Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths that have middleware (Next.js) should route through Cloud Functions #5320

Merged

Conversation

leoortizz
Copy link
Member

Description

Wrapping up #5195

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 56.32% // Head: 56.39% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (23b55da) compared to base (dab23ed).
Patch coverage: 28.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5320      +/-   ##
==========================================
+ Coverage   56.32%   56.39%   +0.07%     
==========================================
  Files         313      314       +1     
  Lines       21078    21102      +24     
  Branches     4282     4286       +4     
==========================================
+ Hits        11872    11901      +29     
+ Misses       8180     8176       -4     
+ Partials     1026     1025       -1     
Impacted Files Coverage Δ
src/frameworks/index.ts 16.14% <0.00%> (-0.07%) ⬇️
src/frameworks/next/index.ts 14.87% <6.48%> (+1.30%) ⬆️
src/frameworks/next/constants.ts 100.00% <100.00%> (ø)
src/frameworks/next/utils.ts 95.83% <100.00%> (+2.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I'm going to pull down and run this locally since we have a lot of refactoring here, I kicked off the integration tests. Add changelog when you can.

src/frameworks/next/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add changelog and we're good

@jamesdaniels jamesdaniels enabled auto-merge (squash) December 13, 2022 21:07
auto-merge was automatically disabled December 13, 2022 21:07

Head branch was pushed to by a user without write access

@jamesdaniels jamesdaniels enabled auto-merge (squash) December 13, 2022 21:12
@jamesdaniels jamesdaniels merged commit 3d89222 into firebase:master Dec 13, 2022
@leoortizz leoortizz deleted the leoortizz_skip_middleware_matches branch December 14, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants