New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paths that have middleware (Next.js) should route through Cloud Functions #5320
Paths that have middleware (Next.js) should route through Cloud Functions #5320
Conversation
Codecov ReportBase: 56.32% // Head: 56.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5320 +/- ##
==========================================
+ Coverage 56.32% 56.39% +0.07%
==========================================
Files 313 314 +1
Lines 21078 21102 +24
Branches 4282 4286 +4
==========================================
+ Hits 11872 11901 +29
+ Misses 8180 8176 -4
+ Partials 1026 1025 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I'm going to pull down and run this locally since we have a lot of refactoring here, I kicked off the integration tests. Add changelog when you can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add changelog and we're good
Head branch was pushed to by a user without write access
Description
Wrapping up #5195