Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Google Cloud Workstations #5283

Merged
merged 4 commits into from Dec 1, 2022

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Dec 1, 2022

Default to --no-localhost when calling login from Cloud Workstations

@TheIronDev

This comment was marked as resolved.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Base: 56.27% // Head: 56.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (02a53c0) compared to base (b2d23b6).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5283   +/-   ##
=======================================
  Coverage   56.27%   56.28%           
=======================================
  Files         309      309           
  Lines       20819    20826    +7     
  Branches     4224     4226    +2     
=======================================
+ Hits        11715    11721    +6     
- Misses       8092     8093    +1     
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/auth/apiSpec.ts 100.00% <ø> (ø)
src/emulator/auth/server.ts 72.54% <66.66%> (+0.66%) ⬆️
src/emulator/auth/operations.ts 83.41% <100.00%> (+0.01%) ⬆️
src/utils.ts 67.46% <100.00%> (+0.34%) ⬆️
src/emulator/auth/state.ts 84.87% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesdaniels jamesdaniels enabled auto-merge (squash) December 1, 2022 16:39
@jamesdaniels jamesdaniels merged commit 6ed818b into master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants