Inlined.web frameworks label #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.13% // Head: 56.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5176 +/- ##
==========================================
+ Coverage 56.13% 56.20% +0.07%
==========================================
Files 308 308
Lines 20734 20737 +3
Branches 4198 4199 +1
==========================================
+ Hits 11638 11655 +17
+ Misses 8086 8069 -17
- Partials 1010 1013 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TheIronDev
approved these changes
Oct 27, 2022
| const versions = await Promise.all( | ||
| configs.map((config) => api.createVersion(config.site, version)) | ||
| configs.map(async (config) => { |
There was a problem hiding this comment.
Please add tests for this change
TheIronDev
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a label to hosting versions with the type of web framework being used. This uses the same id as the google analytics metric, so I moved that track code to the deploy function as well.
Separately, I moved HostingResolved to src/hosting so that I don't feel guilty adding new fields for the sake of communication between web frameworks and hosting.