Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Inlined.web frameworks label (#5176)
* Move HostingResolved out of firebaseConfig * Move metric to deploy code and add label * Add some smoke tests to the hosting pepare library
- Loading branch information
Showing
8 changed files
with
155 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| import { expect } from "chai"; | ||
| import * as sinon from "sinon"; | ||
|
|
||
| import { FirebaseConfig } from "../../../firebaseConfig"; | ||
| import { HostingOptions } from "../../../hosting/options"; | ||
| import { Context } from "../../../deploy/hosting/context"; | ||
| import { Options } from "../../../options"; | ||
| import * as hostingApi from "../../../hosting/api"; | ||
| import * as tracking from "../../../track"; | ||
| import * as deploymentTool from "../../../deploymentTool"; | ||
| import * as config from "../../../hosting/config"; | ||
| import { prepare } from "../../../deploy/hosting"; | ||
|
|
||
| describe("hosting prepare", () => { | ||
| let hostingStub: sinon.SinonStubbedInstance<typeof hostingApi>; | ||
| let trackingStub: sinon.SinonStubbedInstance<typeof tracking>; | ||
| let siteConfig: config.HostingResolved; | ||
| let firebaseJson: FirebaseConfig; | ||
| let options: HostingOptions & Options; | ||
|
|
||
| beforeEach(() => { | ||
| hostingStub = sinon.stub(hostingApi); | ||
| trackingStub = sinon.stub(tracking); | ||
|
|
||
| // We're intentionally using pointer references so that editing site | ||
| // edits the results of hostingConfig() and changes firebase.json | ||
| siteConfig = { | ||
| site: "site", | ||
| public: ".", | ||
| }; | ||
| firebaseJson = { | ||
| hosting: siteConfig, | ||
| }; | ||
| options = { | ||
| cwd: ".", | ||
| configPath: ".", | ||
| only: "", | ||
| except: "", | ||
| filteredTargets: ["HOSTING"], | ||
| force: false, | ||
| json: false, | ||
| nonInteractive: false, | ||
| interactive: true, | ||
| debug: false, | ||
| config: { | ||
| src: firebaseJson, | ||
| } as any, | ||
| rc: null as any, | ||
|
|
||
| // Forces caching behavior of hostingConfig call | ||
| normalizedHostingConfig: [siteConfig], | ||
| }; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| sinon.verifyAndRestore(); | ||
| }); | ||
|
|
||
| it("passes a smoke test with web framework", async () => { | ||
| siteConfig.webFramework = "fake-framework"; | ||
|
|
||
| // Edit the in-memory config to add a web framework | ||
| hostingStub.createVersion.callsFake((siteId, version) => { | ||
| expect(siteId).to.equal(siteConfig.site); | ||
| expect(version.status).to.equal("CREATED"); | ||
| expect(version.labels).to.deep.equal({ | ||
| ...deploymentTool.labels(), | ||
| "firebase-web-framework": "fake-framework", | ||
| }); | ||
| return Promise.resolve("version"); | ||
| }); | ||
|
|
||
| const context: Context = { | ||
| projectId: "project", | ||
| }; | ||
| await prepare(context, options); | ||
|
|
||
| expect(trackingStub.track).to.have.been.calledOnceWith("hosting_deploy", "fake-framework"); | ||
| expect(hostingStub.createVersion).to.have.been.calledOnce; | ||
| expect(context.hosting).to.deep.equal({ | ||
| deploys: [ | ||
| { | ||
| config: siteConfig, | ||
| version: "version", | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| it("passes a smoke test without web framework", async () => { | ||
| // Do not set a web framework on siteConfig | ||
|
|
||
| // Edit the in-memory config to add a web framework | ||
| hostingStub.createVersion.callsFake((siteId, version) => { | ||
| expect(siteId).to.equal(siteConfig.site); | ||
| expect(version.status).to.equal("CREATED"); | ||
| // Note: we're missing the web framework label | ||
| expect(version.labels).to.deep.equal(deploymentTool.labels()); | ||
| return Promise.resolve("version"); | ||
| }); | ||
|
|
||
| const context: Context = { | ||
| projectId: "project", | ||
| }; | ||
| await prepare(context, options); | ||
|
|
||
| expect(trackingStub.track).to.have.been.calledOnceWith("hosting_deploy", "classic"); | ||
| expect(hostingStub.createVersion).to.have.been.calledOnce; | ||
| expect(context.hosting).to.deep.equal({ | ||
| deploys: [ | ||
| { | ||
| config: siteConfig, | ||
| version: "version", | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
| }); |