Skip to content

Commit

Permalink
m
Browse files Browse the repository at this point in the history
  • Loading branch information
fredzqm committed May 10, 2024
1 parent 0597429 commit c890924
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/dataconnect/provisionCloudSql.ts
Expand Up @@ -109,19 +109,19 @@ export function getUpdateReason(instance: Instance, requireGoogleMlIntegration:
const settings = instance.settings;
// CloudSQL instances must have public IP enabled to be used with Firebase Data Connect.
if (!settings.ipConfiguration?.ipv4Enabled) {
reason += "\n - to enable public IP";
reason += "\n - to enable public IP.";
}

if (requireGoogleMlIntegration) {
if (!settings.enableGoogleMlIntegration) {
reason += "\n - to enable Google ML integration";
reason += "\n - to enable Google ML integration.";
}
if (
!settings.databaseFlags?.some(
(f) => f.name === "cloudsql.enable_google_ml_integration" && f.value === "on",
)
) {
reason += "\n - to enable Google ML integration database flag";
reason += "\n - to enable Google ML integration database flag.";
}
}

Expand All @@ -131,7 +131,7 @@ export function getUpdateReason(instance: Instance, requireGoogleMlIntegration:
(f) => f.name === "cloudsql.iam_authentication" && f.value === "on",
) ?? false;
if (!isIamEnabled) {
reason += "\n - to enable IAM authentication database flag";
reason += "\n - to enable IAM authentication database flag.";
}

return reason;
Expand Down

0 comments on commit c890924

Please sign in to comment.