Crashlytics fix cache directory on Windows (#3842)

firebase · Oct 18, 2021 · a45a8fc · a45a8fc
1 parent d06d46b
commit a45a8fc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1 +1,2 @@
 - Fix Auth Emulator deleteTenant not working with Node Admin (#3817).
+- Fix Crashlytics Android Native Symbols not working on Windows due to ":" in the path (#3842)
diff --git a/src/commands/crashlytics-symbols-upload.ts b/src/commands/crashlytics-symbols-upload.ts
@@ -69,7 +69,8 @@ export default new Command("crashlytics:symbols:upload <symbolFiles...>")
         SYMBOL_CACHE_ROOT_DIR,
         `crashlytics-${uuid.v4()}`,
         "nativeSymbols",
-        app,
+        // Windows does not allow ":" in their directory names
+        app.replace(/:/g, "-"),
         generator
       ),
       symbolFile: "",