nits

firebase · May 10, 2024 · 781b8a4 · 781b8a4
1 parent 7b33e7e
commit 781b8a4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/dataconnect/schemaMigration.ts b/src/dataconnect/schemaMigration.ts
@@ -301,7 +301,7 @@ async function ensureServiceIsConnectedToCloudSql(
   if (postgresql?.cloudSql.instance !== instanceId) {
     logLabeledWarning(
       "dataconnect",
-      `Switching connected Cloud SQL instance\nFrom ${postgresql?.cloudSql.instance}\nTo\n ${instanceId}`,
+      `Switching connected Cloud SQL instance\nFrom ${postgresql?.cloudSql.instance}\nTo ${instanceId}`,
     );
   }
   if (postgresql?.database !== databaseId) {
@@ -313,6 +313,7 @@ async function ensureServiceIsConnectedToCloudSql(
   if (!postgresql || postgresql.schemaValidation === "STRICT") {
     return;
   }
+  postgresql.schemaValidation = "STRICT";
   try {
     await upsertSchema(currentSchema, /** validateOnly=*/ false);
   } catch (err: any) {

diff --git a/src/gcp/cloudsql/cloudsqladmin.ts b/src/gcp/cloudsql/cloudsqladmin.ts
@@ -51,6 +51,8 @@ export async function createInstance(
       userLabels: { "firebase-data-connect": "ft" },
       insightsConfig: {
         queryInsightsEnabled: true,
+				queryPlansPerMinute:  5,    // Match the default settings
+				queryStringLength:    1024, // Match the default settings
       },
     },
   });

diff --git a/src/gcp/cloudsql/types.ts b/src/gcp/cloudsql/types.ts
@@ -56,6 +56,8 @@ export interface DatabaseFlag {
 
 interface InsightsConfig {
   queryInsightsEnabled: boolean;
+  queryPlansPerMinute:  number;
+  queryStringLength:    number;
 }
 
 // TODO: Consider splitting off return only fields and input fields into different types.