Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the context on cancel callback handler. #8204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AlastairTaft
Copy link

@AlastairTaft AlastairTaft commented Apr 25, 2024

I have an issue where there is an unhandled promise rejection throwing, but I have an error handler on this scenario, it looks something like this

const Display = function(deviceId){
  Component.call(this)
  this.bindedOnUnhandledRejection_ = this.onUnhandledRejection_.bind(this)
}

Display.prototype.addEventListeners = function(){
  window.addEventListener("unhandledrejection", this.bindedOnUnhandledRejection_)
}

Display.prototype.onUnhandledRejection_ = function(event){
  this.logger_.log({
    message: event.reason instanceof Error ? 
      event.reason.message :
      String(event.reason), 
    type: 'ERROR',
  }, {
    'reason': maybeConvertErrorToSerializableObject(event.reason),
  })
  this.paintErrors_()
}

My issue is that onUnhandledRejection_ is getting called from Firebase, and Firebase is removing the context from my function. So the error comes in and this.logger_ is undefined.

I'm proposing that Firebase should not be messing with my function context.

Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: 3f800e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AlastairTaft AlastairTaft marked this pull request as ready for review April 25, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant