Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigating additional stats events. #8196

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Investigating additional stats events. #8196

wants to merge 4 commits into from

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024 •
edited

⚠️ No Changeset found

Latest commit: 0f150bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2024 •
edited

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (03069bb)Merge (63863db)Diff
    browser377 kB377 kB+88 B (+0.0%)
    esm5362 kB362 kB+96 B (+0.0%)
    module377 kB377 kB+88 B (+0.0%)
    react-native377 kB377 kB+88 B (+0.0%)

  • bundle

    TypeBase (03069bb)Merge (63863db)Diff
    firestore (CSI Auto Indexing Disable and Delete)269 kB269 kB+73 B (+0.0%)
    firestore (CSI Auto Indexing Enable)269 kB269 kB+73 B (+0.0%)
    firestore (Persistence)303 kB303 kB+73 B (+0.0%)
    firestore (Query Cursors)241 kB241 kB+73 B (+0.0%)
    firestore (Query)238 kB238 kB+73 B (+0.0%)
    firestore (Read data once)226 kB226 kB+73 B (+0.0%)
    firestore (Read Write w Persistence)323 kB323 kB+73 B (+0.0%)
    firestore (Realtime updates)229 kB229 kB+73 B (+0.0%)
    firestore (Transaction)205 kB205 kB+73 B (+0.0%)
    firestore (Write data)205 kB205 kB+73 B (+0.0%)

  • firebase

    TypeBase (03069bb)Merge (63863db)Diff
    firebase-compat.js786 kB786 kB+73 B (+0.0%)
    firebase-firestore-compat.js342 kB342 kB+73 B (+0.0%)
    firebase-firestore.js436 kB436 kB+88 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dE8zZ4kYXr.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 22, 2024 •
edited

Size Analysis Report 1

Affected Products

  • @firebase/firestore

    • addDoc

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size124 kB124 kB+72 B (+0.1%)
      size-with-ext-deps196 kB196 kB+73 B (+0.0%)

    • deleteDoc

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size115 kB115 kB+72 B (+0.1%)
      size-with-ext-deps187 kB187 kB+73 B (+0.0%)

    • disableNetwork

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size103 kB103 kB+72 B (+0.1%)
      size-with-ext-deps175 kB175 kB+73 B (+0.0%)

    • enableIndexedDbPersistence

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size186 kB186 kB+72 B (+0.0%)
      size-with-ext-deps259 kB259 kB+73 B (+0.0%)

    • enableMultiTabIndexedDbPersistence

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size222 kB222 kB+72 B (+0.0%)
      size-with-ext-deps295 kB295 kB+73 B (+0.0%)

    • enableNetwork

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size103 kB103 kB+72 B (+0.1%)
      size-with-ext-deps175 kB175 kB+73 B (+0.0%)

    • executeWrite

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size114 kB114 kB+72 B (+0.1%)
      size-with-ext-deps186 kB186 kB+73 B (+0.0%)

    • getAggregateFromServer

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size110 kB110 kB+72 B (+0.1%)
      size-with-ext-deps182 kB182 kB+73 B (+0.0%)

    • getCountFromServer

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size110 kB110 kB+72 B (+0.1%)
      size-with-ext-deps183 kB183 kB+73 B (+0.0%)

    • getDoc

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size144 kB145 kB+72 B (+0.0%)
      size-with-ext-deps217 kB217 kB+73 B (+0.0%)

    • getDocFromServer

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size145 kB145 kB+72 B (+0.0%)
      size-with-ext-deps217 kB217 kB+73 B (+0.0%)

    • getDocs

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size146 kB146 kB+72 B (+0.0%)
      size-with-ext-deps219 kB219 kB+73 B (+0.0%)

    • getDocsFromServer

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size146 kB146 kB+72 B (+0.0%)
      size-with-ext-deps218 kB218 kB+73 B (+0.0%)

    • loadBundle

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size112 kB112 kB+72 B (+0.1%)
      size-with-ext-deps185 kB185 kB+73 B (+0.0%)

    • memoryLocalCache

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size100 kB100 kB+72 B (+0.1%)
      size-with-ext-deps172 kB172 kB+73 B (+0.0%)

    • onSnapshot

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size147 kB147 kB+72 B (+0.0%)
      size-with-ext-deps219 kB219 kB+73 B (+0.0%)

    • onSnapshotsInSync

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size136 kB136 kB+72 B (+0.1%)
      size-with-ext-deps208 kB208 kB+73 B (+0.0%)

    • persistentLocalCache

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size183 kB184 kB+72 B (+0.0%)
      size-with-ext-deps256 kB256 kB+73 B (+0.0%)

    • persistentMultipleTabManager

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size219 kB219 kB+72 B (+0.0%)
      size-with-ext-deps292 kB292 kB+73 B (+0.0%)

    • persistentSingleTabManager

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size183 kB183 kB+72 B (+0.0%)
      size-with-ext-deps256 kB256 kB+73 B (+0.0%)

    • runTransaction

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size124 kB124 kB+72 B (+0.1%)
      size-with-ext-deps196 kB196 kB+73 B (+0.0%)

    • setDoc

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size123 kB123 kB+72 B (+0.1%)
      size-with-ext-deps195 kB195 kB+73 B (+0.0%)

    • updateDoc

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size123 kB123 kB+72 B (+0.1%)
      size-with-ext-deps196 kB196 kB+73 B (+0.0%)

    • waitForPendingWrites

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size103 kB103 kB+72 B (+0.1%)
      size-with-ext-deps176 kB176 kB+73 B (+0.0%)

    • writeBatch

      Size

      TypeBase (03069bb)Merge (63863db)Diff
      size125 kB125 kB+72 B (+0.1%)
      size-with-ext-deps198 kB198 kB+73 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XHXHbwND2I.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarkDuckworth @google-oss-bot