Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Query/AggregateQuery to proto representation #8177

Merged
merged 8 commits into from May 2, 2024

Conversation

ehsannas
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: 596dadb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ehsannas ehsannas force-pushed the ehsann/query-to-proto-internal branch from 6c36bde to 123f953 Compare April 17, 2024 22:00
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2024

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (3376384)Merge (2b4eb32)Diff
    browser377 kB378 kB+1.32 kB (+0.4%)
    esm5362 kB363 kB+1.01 kB (+0.3%)
    main580 kB582 kB+1.91 kB (+0.3%)
    module377 kB378 kB+1.32 kB (+0.4%)
    react-native377 kB378 kB+1.32 kB (+0.3%)
  • @firebase/firestore-lite

    TypeBase (3376384)Merge (2b4eb32)Diff
    browser109 kB109 kB+12 B (+0.0%)
    esm5106 kB106 kB+12 B (+0.0%)
    main150 kB150 kB+42 B (+0.0%)
    module109 kB109 kB+12 B (+0.0%)
    react-native109 kB109 kB+12 B (+0.0%)
  • @firebase/webchannel-wrapper

    TypeBase (3376384)Merge (2b4eb32)Diff
    main65.4 kB38 B-65.4 kB (-99.9%)
  • @firebase/webchannel-wrapper/bloom-blob

    TypeBase (3376384)Merge (2b4eb32)Diff
    browser?11.1 kB? (?)
    esm5?11.1 kB? (?)
    main?11.1 kB? (?)
    module?11.1 kB? (?)
  • @firebase/webchannel-wrapper/webchannel-blob

    TypeBase (3376384)Merge (2b4eb32)Diff
    browser?44.3 kB? (?)
    esm5?55.6 kB? (?)
    main?44.3 kB? (?)
    module?44.3 kB? (?)
  • bundle

    TypeBase (3376384)Merge (2b4eb32)Diff
    firestore (CSI Auto Indexing Disable and Delete)268 kB270 kB+1.68 kB (+0.6%)
    firestore (CSI Auto Indexing Enable)268 kB270 kB+1.68 kB (+0.6%)
    firestore (Persistence)303 kB305 kB+1.75 kB (+0.6%)
    firestore (Query Cursors)247 kB242 kB-4.79 kB (-1.9%)
    firestore (Query)245 kB240 kB-4.79 kB (-2.0%)
    firestore (Read data once)233 kB228 kB-4.79 kB (-2.1%)
    firestore (Read Write w Persistence)323 kB324 kB+1.75 kB (+0.5%)
    firestore (Realtime updates)235 kB230 kB-4.79 kB (-2.0%)
    firestore (Transaction)212 kB207 kB-4.90 kB (-2.3%)
    firestore (Write data)212 kB207 kB-4.82 kB (-2.3%)
  • firebase

    TypeBase (3376384)Merge (2b4eb32)Diff
    firebase-compat.js786 kB787 kB+1.73 kB (+0.2%)
    firebase-firestore-compat.js342 kB343 kB+1.28 kB (+0.4%)
    firebase-firestore-lite.js117 kB117 kB+12 B (+0.0%)
    firebase-firestore.js436 kB439 kB+2.72 kB (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xETDMZT8hZ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2024

Size Analysis Report 1

This report is too large (810,796 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ihP0l3t2Jv.html

@ehsannas ehsannas marked this pull request as ready for review May 2, 2024 00:17
@ehsannas ehsannas requested review from a team as code owners May 2, 2024 00:17
@ehsannas ehsannas self-assigned this May 2, 2024
@ehsannas ehsannas changed the title WIP: [internal] Query/AggregateQuery to proto representation [internal] Query/AggregateQuery to proto representation May 2, 2024
@ehsannas ehsannas assigned MarkDuckworth and unassigned ehsannas May 2, 2024
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider updating the return types for the new functions.

@ehsannas ehsannas merged commit f25b9e5 into master May 2, 2024
44 checks passed
@ehsannas ehsannas deleted the ehsann/query-to-proto-internal branch May 2, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants