Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vertex SDK #8119

Merged
merged 32 commits into from May 8, 2024
Merged

Add Vertex SDK #8119

merged 32 commits into from May 8, 2024

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Apr 3, 2024

Merge Vertex feature branch

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2024 •
edited

🦋 Changeset detected

Latest commit: f6a2b88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
firebase Minor
@firebase/vertexai-preview Patch
@firebase/app Patch
@firebase/app-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 3, 2024 •
edited

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (4b49630)Merge (ca18551)Diff
    browser18.1 kB18.1 kB+65 B (+0.4%)
    esm523.6 kB23.7 kB+67 B (+0.3%)
    main24.7 kB24.8 kB+67 B (+0.3%)
    module18.1 kB18.1 kB+65 B (+0.4%)

  • @firebase/firestore

    TypeBase (4b49630)Merge (ca18551)Diff
    browser377 kB378 kB+927 B (+0.2%)
    esm5362 kB363 kB+546 B (+0.2%)
    main580 kB582 kB+1.50 kB (+0.3%)
    module377 kB378 kB+927 B (+0.2%)
    react-native377 kB378 kB+927 B (+0.2%)

  • @firebase/firestore-lite

    TypeBase (4b49630)Merge (ca18551)Diff
    browser109 kB109 kB+12 B (+0.0%)
    esm5106 kB106 kB+12 B (+0.0%)
    main150 kB150 kB+42 B (+0.0%)
    module109 kB109 kB+12 B (+0.0%)
    react-native109 kB109 kB+12 B (+0.0%)

  • @firebase/vertexai-preview

    TypeBase (4b49630)Merge (ca18551)Diff
    browser?25.2 kB? (?)
    main?25.8 kB? (?)
    module?25.2 kB? (?)

  • @firebase/webchannel-wrapper/webchannel-blob

    TypeBase (4b49630)Merge (ca18551)Diff
    browser44.3 kB42.2 kB-2.15 kB (-4.9%)
    esm555.6 kB53.4 kB-2.21 kB (-4.0%)
    main44.3 kB42.2 kB-2.15 kB (-4.9%)
    module44.3 kB42.2 kB-2.15 kB (-4.9%)

  • bundle

    46 size changes

    TypeBase (4b49630)Merge (ca18551)Diff
    analytics (logEvent)44.4 kB44.5 kB+57 B (+0.1%)
    app-check (CustomProvider)37.3 kB37.3 kB+57 B (+0.2%)
    app-check (ReCaptchaEnterpriseProvider)39.8 kB39.9 kB+57 B (+0.1%)
    app-check (ReCaptchaV3Provider)39.8 kB39.8 kB+57 B (+0.1%)
    auth (Anonymous)76.0 kB76.0 kB+57 B (+0.1%)
    auth (EmailAndPassword)84.3 kB84.3 kB+57 B (+0.1%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB+57 B (+0.1%)
    auth (GooglePopup)100 kB100 kB+57 B (+0.1%)
    auth (GoogleRedirect)101 kB101 kB+57 B (+0.1%)
    auth (Phone)86.6 kB86.7 kB+57 B (+0.1%)
    database (Append to a list of data)149 kB149 kB+57 B (+0.0%)
    database (Filtering data)148 kB148 kB+57 B (+0.0%)
    database (Listen for child events)164 kB164 kB+57 B (+0.0%)
    database (Listen for value events + Detach listeners)164 kB164 kB+57 B (+0.0%)
    database (Listen for value events)164 kB164 kB+57 B (+0.0%)
    database (Read data once)164 kB164 kB+57 B (+0.0%)
    database (Save data as transactions)166 kB166 kB+57 B (+0.0%)
    database (Sort data)149 kB150 kB+57 B (+0.0%)
    database (Write data)148 kB148 kB+57 B (+0.0%)
    firestore (CSI Auto Indexing Disable and Delete)270 kB268 kB-2.12 kB (-0.8%)
    firestore (CSI Auto Indexing Enable)270 kB268 kB-2.12 kB (-0.8%)
    firestore (Persistence)305 kB303 kB-2.12 kB (-0.7%)
    firestore (Query Cursors)242 kB240 kB-2.12 kB (-0.9%)
    firestore (Query)240 kB238 kB-2.12 kB (-0.9%)
    firestore (Read data once)228 kB226 kB-2.12 kB (-0.9%)
    firestore (Read Write w Persistence)324 kB322 kB-2.12 kB (-0.7%)
    firestore (Realtime updates)230 kB228 kB-2.12 kB (-0.9%)
    firestore (Transaction)207 kB205 kB-2.12 kB (-1.0%)
    firestore (Write data)207 kB205 kB-2.12 kB (-1.0%)
    firestore-lite (Query Cursors)89.8 kB89.8 kB+57 B (+0.1%)
    firestore-lite (Query)85.9 kB85.9 kB+57 B (+0.1%)
    firestore-lite (Read data once)62.1 kB62.1 kB+57 B (+0.1%)
    firestore-lite (Transaction)87.0 kB87.1 kB+57 B (+0.1%)
    firestore-lite (Write data)71.6 kB71.7 kB+57 B (+0.1%)
    functions (call)31.8 kB31.9 kB+57 B (+0.2%)
    messaging (send + receive)46.8 kB46.9 kB+57 B (+0.1%)
    performance (trace)51.6 kB51.7 kB+57 B (+0.1%)
    remote-config (getAndFetch)46.2 kB46.2 kB+57 B (+0.1%)
    storage (getBytes)42.0 kB42.0 kB+57 B (+0.1%)
    storage (getDownloadURL)44.0 kB44.1 kB+57 B (+0.1%)
    storage (getMetadata)43.5 kB43.5 kB+57 B (+0.1%)
    storage (list + listAll)42.9 kB43.0 kB+57 B (+0.1%)
    storage (updateMetadata)43.7 kB43.8 kB+57 B (+0.1%)
    storage (uploadBytes)48.6 kB48.7 kB+57 B (+0.1%)
    storage (uploadBytesResumable)58.5 kB58.6 kB+57 B (+0.1%)
    storage (uploadString)48.8 kB48.9 kB+57 B (+0.1%)

  • firebase

    TypeBase (4b49630)Merge (ca18551)Diff
    firebase-app-compat.js31.4 kB31.4 kB+43 B (+0.1%)
    firebase-app.js102 kB102 kB+76 B (+0.1%)
    firebase-compat.js787 kB786 kB-1.99 kB (-0.3%)
    firebase-firestore-compat.js343 kB341 kB-2.03 kB (-0.6%)
    firebase-firestore-lite.js117 kB117 kB+12 B (+0.0%)
    firebase-firestore.js438 kB437 kB-1.17 kB (-0.3%)
    firebase-performance-standalone-compat.es2017.js93.3 kB93.3 kB+43 B (+0.0%)
    firebase-performance-standalone-compat.js70.3 kB70.4 kB+47 B (+0.1%)
    firebase-vertexai-preview.js?19.3 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BnKz9WuBnq.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 3, 2024 •
edited

Size Analysis Report 1

This report is too large (232,623 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TjhDtmGn38.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

hsubox76 and others added 3 commits May 6, 2024 20:09
@hsubox76
Update API reports
dc2efe7
@hsubox76
fix test (#8228)
4c83b34
@hsubox76 @rachelsaunders
Generate vertex reference docs (#8226)
f688228 
* generate vertex reference docs

* Update docs-devsite/index.md

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* Update docs-devsite/vertexai-preview.vertexaioptions.md

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* addressed PR comments

* regenerate

---------

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
@hsubox76 hsubox76 marked this pull request as ready for review May 7, 2024 21:54
@hsubox76 hsubox76 requested a review from a team as a code owner May 8, 2024 17:18
hsubox76 and others added 2 commits May 8, 2024 11:45
@hsubox76 @rachelsaunders
Fix doc comments (#8234)
c66445c 
* fix doc comments

* fix one more comment

* Update docs-devsite/vertexai-preview.md

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

---------

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
@DellaBitta
[Vertex AI] Add a responseMimeType to generationConfig (#8235)
f6a2b88 
Provide Apps with an ability to configure the responseMimeType. This enables applications to request that VertexAI returns the response in a JSON format instead of a normal textual format.
rachelsaunders
rachelsaunders approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@rachelsaunders rachelsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for docs content

@hsubox76 hsubox76 merged commit 506b8a6 into master May 8, 2024
43 of 44 checks passed
@hsubox76 hsubox76 deleted the ch-vertex-feature branch May 8, 2024 21:28
@google-oss-bot google-oss-bot mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@rachelsaunders rachelsaunders rachelsaunders approved these changes

@dlarocque dlarocque dlarocque approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@markarndt markarndt Awaiting requested review from markarndt

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hsubox76 @google-oss-bot @DellaBitta @rachelsaunders @dlarocque