Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node-fetch to v3 #7359

Closed
wants to merge 1 commit into from

Conversation

raajnadar
Copy link
Contributor

WIP trying to upgrade node fetch to v3 to fix #7280

@changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2023

⚠️ No Changeset found

Latest commit: 513f1d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marck283
Copy link

marck283 commented Oct 2, 2023

Due to a Regular Expression Denial of Service bug (see here for some information on the vulnerability and #7660 for the reported issue), I suggest upgrading node-fetch to version 3.2.10 or later, since node-fetch@3.2.10 is the earliest version that is not vulnerable to either the REDoS bug or #7660.

@raajnadar
Copy link
Contributor Author

It is better I close the PR we already have some changes in the repo

@raajnadar raajnadar closed this Nov 20, 2023
@raajnadar raajnadar deleted the upgrade-node-fetch-v3 branch November 20, 2023 07:48
@firebase firebase locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Can't resolve encoding" warning in the console when used with Next JS 13.4
2 participants