add BloomFilter class #6795

milaGGL · 2022-11-14T21:49:05Z

Add BloomFilter class

add a constructor that takes a bitmap, padding and hashcount
validate constructor input against empty bloom filter and negative input values
add mightContain method to BloomFilter
add tests for bloom filter input validation
copy paste golden tests from backend
add tests to make sure mightContain result is in sync with backend(use golden tests)
import MD5, Integer from google closure library

changeset-bot · 2022-11-14T21:49:08Z

⚠️ No Changeset found

Latest commit: 1440908

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2022-11-14T21:51:29Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2022-11-14T22:17:10Z

Size Report ¹

Affected Products

@firebase/webchannel-wrapper
Type Base (a2c1c24) Merge (7e32e27) Diff
esm5 44.7 kB 55.2 kB +10.5 kB (+23.6%)
main 54.6 kB 65.1 kB +10.5 kB (+19.3%)
module 42.4 kB 52.9 kB +10.5 kB (+24.8%)

`bundle`

Type	Base (`a2c1c24`)	Merge (`7e32e27`)	Diff
firestore (Persistence)	281 kB	291 kB	+10.5 kB (+3.8%)
firestore (Query Cursors)	220 kB	230 kB	+10.5 kB (+4.8%)
firestore (Query)	217 kB	228 kB	+10.5 kB (+4.8%)
firestore (Read data once)	204 kB	215 kB	+10.5 kB (+5.2%)
firestore (Realtime updates)	207 kB	217 kB	+10.5 kB (+5.1%)
firestore (Transaction)	188 kB	198 kB	+10.5 kB (+5.6%)
firestore (Write data)	188 kB	198 kB	+10.5 kB (+5.6%)

firebase
Type Base (a2c1c24) Merge (7e32e27) Diff
firebase-compat.js 746 kB 756 kB +10.4 kB (+1.4%)
firebase-firestore-compat.js 319 kB 330 kB +10.4 kB (+3.2%)
firebase-firestore.js 321 kB 331 kB +10.5 kB (+3.3%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/xskoCYbgK7.html

google-oss-bot · 2022-11-14T22:25:19Z

Size Analysis Report ¹

This report is too large (144,802 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/XfT4rjgKFV.html

…e to not being able to find the reset() method)

…la/BloomFilter-add-BloomFilter-class

This reverts commit 4a3fb11.

…Filter-class"" This reverts commit 810d63b.

dconeybe

More feedback :) Thanks for addressing the comments from the last round of review.

packages/firestore/src/remote/bloom_filter.ts

packages/firestore/test/unit/remote/bloom_filter.test.ts

packages/firestore/test/unit/remote/bloom_filter_golden_test_data/index.ts

packages/firestore/src/remote/bloom_filter.ts

dconeybe

Thanks for the updates! More feedback :)

packages/firestore/src/remote/bloom_filter.ts

packages/firestore/test/unit/remote/bloom_filter.test.ts

packages/firestore/test/unit/remote/bloom_filter_golden_test_data/index.ts

packages/firestore/test/unit/remote/bloom_filter.test.ts

packages/firestore/src/remote/bloom_filter.ts

packages/firestore/test/unit/remote/bloom_filter.test.ts

dconeybe · 2022-11-29T21:05:56Z

FYI #6833 has been merged into master, which should fix the issues with the "Test Firestore" and "Test All Packages" GitHub Actions. Please merge in the latest from master at your earliest convenience.

packages/firestore/test/unit/core/webchannel_wrapper.test.ts

dconeybe

Approved! Thanks for working on this!

add md5.js package

7122bab

milaGGL changed the base branch from master to mila/BloomFilter November 14, 2022 21:54

milaGGL changed the base branch from mila/BloomFilter to master November 14, 2022 22:07

milaGGL changed the base branch from master to mila/BloomFilter November 14, 2022 22:07

remove noises due to format

3c38d56

milaGGL and others added 12 commits November 14, 2022 14:40

remove changes to yarn lock

eeef62f

use crypto.js instead of md5.js

389de2e

add mightContain method to BloomFilter

dd2e42f

discard string representation of md5 hash value, use byte array instead

3c273e9

Use DateView instead of Buffer

854195c

Added Md5 to webchannel-wrapper

84ef93e

webchannel_wrapper.test.ts added with 1 test (that currently fails du…

877afce

…e to not being able to find the reset() method)

webchannel-wrapper/src/index.js: fix Md5 prototype definition

02f74ff

webchannel_wrapper.test.ts added

398c166

webchannel_wrapper.test.ts: fix imports to make lint happy

01de4cf

Merge remote-tracking branch 'origin/dconeybe/Md5FromClosure' into mi…

c3b9b42

…la/BloomFilter-add-BloomFilter-class

Add golden test, use MD5 from google library

ba8967a

milaGGL changed the base branch from mila/BloomFilter to master November 18, 2022 23:06

milaGGL changed the base branch from master to mila/BloomFilter November 18, 2022 23:07

milaGGL added 2 commits November 18, 2022 15:32

Use number in bitmap instead of hexadecimal string representation

5abbe86

add golden test files

dca8d99

dconeybe mentioned this pull request Nov 22, 2022

DO NOT MERGE: Import Integer from google-closure-library #6813

Closed

dconeybe and others added 4 commits November 22, 2022 13:27

REVERT ME: require() test for json/txt

4a3fb11

Revert "REVERT ME: require() test for json/txt"

3a22a98

This reverts commit 4a3fb11.

import golden tests without fs, use Integer instead of BigInt

9ccde39

add the Integer library

0d919c1

milaGGL requested a review from hsubox76 as a code owner November 25, 2022 00:51

Revert "Revert "Merge branch 'master' into mila/BloomFilter-add-Bloom…

01bd93e

…Filter-class"" This reverts commit 810d63b.

milaGGL requested a review from dconeybe November 25, 2022 17:46

dconeybe requested changes Nov 25, 2022

View reviewed changes

milaGGL added 2 commits November 25, 2022 21:48

resolve comments

10b1b67

remove type casting on TEST_DATA

06f6400

milaGGL commented Nov 27, 2022

View reviewed changes

packages/firestore/src/remote/bloom_filter.ts Outdated Show resolved Hide resolved

dconeybe requested changes Nov 28, 2022

View reviewed changes

resolve comments

b3a7784

milaGGL commented Nov 29, 2022

View reviewed changes

packages/firestore/test/unit/remote/bloom_filter.test.ts Show resolved Hide resolved

run yarn format

4aaecda

milaGGL requested a review from dconeybe November 29, 2022 01:42

dconeybe requested changes Nov 29, 2022

View reviewed changes

milaGGL added 2 commits November 29, 2022 13:08

Merge branch 'master' into mila/BloomFilter-add-BloomFilter-class

9321eec

resolve comments

9a11614

milaGGL requested review from avolkovi, lisajian, sam-gc and yuchenshi as code owners November 29, 2022 22:19

milaGGL changed the base branch from mila/BloomFilter to master November 29, 2022 22:20

milaGGL changed the base branch from master to mila/BloomFilter November 29, 2022 22:20

milaGGL requested a review from dconeybe November 29, 2022 23:13

dconeybe requested changes Nov 30, 2022

View reviewed changes

packages/firestore/test/unit/core/webchannel_wrapper.test.ts Outdated Show resolved Hide resolved

resolve comments

1440908

milaGGL requested a review from dconeybe November 30, 2022 07:19

dconeybe approved these changes Nov 30, 2022

View reviewed changes

milaGGL merged commit c17af51 into mila/BloomFilter Nov 30, 2022

milaGGL deleted the mila/BloomFilter-add-BloomFilter-class branch November 30, 2022 18:01

firebase locked and limited conversation to collaborators Dec 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add BloomFilter class #6795

add BloomFilter class #6795

milaGGL commented Nov 14, 2022 •

edited

changeset-bot bot commented Nov 14, 2022 •

edited

github-actions bot commented Nov 14, 2022 •

edited

google-oss-bot commented Nov 14, 2022 •

edited

`@firebase/webchannel-wrapper`

`bundle`

`firebase`

google-oss-bot commented Nov 14, 2022 •

edited

dconeybe left a comment

dconeybe left a comment

dconeybe commented Nov 29, 2022

dconeybe left a comment

add BloomFilter class #6795

add BloomFilter class #6795

Conversation

milaGGL commented Nov 14, 2022 • edited

changeset-bot bot commented Nov 14, 2022 • edited

⚠️ No Changeset found

github-actions bot commented Nov 14, 2022 • edited

Changeset File Check ✅

google-oss-bot commented Nov 14, 2022 • edited

Size Report 1

Affected Products

@firebase/webchannel-wrapper

bundle

firebase

Test Logs

google-oss-bot commented Nov 14, 2022 • edited

Size Analysis Report 1

Test Logs

dconeybe left a comment

Choose a reason for hiding this comment

dconeybe left a comment

Choose a reason for hiding this comment

dconeybe commented Nov 29, 2022

dconeybe left a comment

Choose a reason for hiding this comment

milaGGL commented Nov 14, 2022 •

edited

changeset-bot bot commented Nov 14, 2022 •

edited

github-actions bot commented Nov 14, 2022 •

edited

google-oss-bot commented Nov 14, 2022 •

edited

Size Report ¹

`@firebase/webchannel-wrapper`

`bundle`

`firebase`

google-oss-bot commented Nov 14, 2022 •

edited

Size Analysis Report ¹