New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Unused 'messaging-types' #6750
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also delete the line in CODEOWNERS?
packages/messaging-types @zwu52 @firebase/jssdk-global-approvers
Size Report 1Affected ProductsNo changes between base commit (9e9ee7b) and merge commit (0bd2cd4).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (9e9ee7b) and merge commit (0bd2cd4).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Currently only types in @messaging & @messaging-interop-types are used by the main and compact package.