Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forced get to wait until db is online #6340

Merged
merged 17 commits into from Jun 27, 2022
Merged

Forced get to wait until db is online #6340

merged 17 commits into from Jun 27, 2022
+79 −34

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Jun 7, 2022 •
edited

get() should wait until db is online to resolve its outstanding get. Fixes #6036 for RTDB

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2022 •
edited

🦋 Changeset detected

Latest commit: 0e4c57d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@firebase/database Patch
@firebase/util Patch
@firebase/database-compat Patch
firebase Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/auth-compat Patch
@firebase/auth Patch
@firebase/component Patch
@firebase/database-types Patch
@firebase/firestore-compat Patch
@firebase/firestore Patch
@firebase/functions-compat Patch
@firebase/functions Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 8, 2022 •
edited

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (efe2000)Merge (de09f57)Diff
    browser19.0 kB19.1 kB+178 B (+0.9%)
    esm523.6 kB23.8 kB+178 B (+0.8%)
    main24.7 kB24.9 kB+178 B (+0.7%)
    module19.0 kB19.1 kB+178 B (+0.9%)

  • @firebase/database

    TypeBase (efe2000)Merge (de09f57)Diff
    browser249 kB248 kB-404 B (-0.2%)
    esm5277 kB276 kB-427 B (-0.2%)
    main282 kB282 kB-427 B (-0.2%)
    module249 kB248 kB-404 B (-0.2%)

  • @firebase/database-compat/standalone

    TypeBase (efe2000)Merge (de09f57)Diff
    main371 kB371 kB-427 B (-0.1%)

  • @firebase/messaging

    TypeBase (efe2000)Merge (de09f57)Diff
    browser21.3 kB21.3 kB+53 B (+0.2%)
    esm526.6 kB26.7 kB+53 B (+0.2%)
    main27.3 kB27.4 kB+53 B (+0.2%)
    module21.3 kB21.3 kB+53 B (+0.2%)

  • @firebase/messaging-sw

    TypeBase (efe2000)Merge (de09f57)Diff
    main30.0 kB30.1 kB+53 B (+0.2%)
    module23.3 kB23.3 kB+53 B (+0.2%)

  • @firebase/util

    TypeBase (efe2000)Merge (de09f57)Diff
    browser20.7 kB21.0 kB+258 B (+1.2%)
    esm522.0 kB22.3 kB+302 B (+1.4%)
    main26.9 kB27.3 kB+404 B (+1.5%)
    module20.7 kB21.0 kB+258 B (+1.2%)

  • bundle

    11 size changes

    TypeBase (efe2000)Merge (de09f57)Diff
    analytics (logEvent)41.6 kB41.8 kB+138 B (+0.3%)
    database (Append to a list of data)145 kB145 kB-332 B (-0.2%)
    database (Filtering data)144 kB144 kB-332 B (-0.2%)
    database (Listen for child events)160 kB160 kB-332 B (-0.2%)
    database (Listen for value events + Detach listeners)160 kB160 kB-332 B (-0.2%)
    database (Listen for value events)160 kB160 kB-332 B (-0.2%)
    database (Read data once)157 kB156 kB-332 B (-0.2%)
    database (Save data as transactions)162 kB162 kB-332 B (-0.2%)
    database (Sort data)146 kB145 kB-332 B (-0.2%)
    database (Write data)144 kB144 kB-332 B (-0.2%)
    messaging (send + receive)45.1 kB45.1 kB+49 B (+0.1%)

  • firebase

    TypeBase (efe2000)Merge (de09f57)Diff
    firebase-analytics-compat.js25.6 kB25.8 kB+136 B (+0.5%)
    firebase-analytics.js111 kB112 kB+241 B (+0.2%)
    firebase-auth-react-native.js496 kB498 kB+1.04 kB (+0.2%)
    firebase-compat.js794 kB794 kB-92 B (-0.0%)
    firebase-database-compat.js166 kB166 kB-306 B (-0.2%)
    firebase-database.js607 kB606 kB-692 B (-0.1%)
    firebase-messaging-compat.js38.1 kB38.2 kB+78 B (+0.2%)
    firebase-messaging-sw.js107 kB107 kB+71 B (+0.1%)
    firebase-messaging.js106 kB106 kB+71 B (+0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5uVf5CK2K9.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 8, 2022 •
edited

Size Analysis Report 1

This report is too large (346,285 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eZpsYVKkz3.html

@maneesht maneesht marked this pull request as ready for review June 17, 2022 04:11
@jmwski jmwski assigned maneesht and unassigned jmwski Jun 17, 2022
@maneesht maneesht assigned jsdt and unassigned maneesht Jun 17, 2022
@egilmorez egilmorez requested a review from markarndt June 20, 2022 14:13
@maneesht maneesht assigned hsubox76 and unassigned jsdt Jun 23, 2022
@maneesht maneesht merged commit b12af44 into master Jun 27, 2022
@maneesht maneesht deleted the mtewani/fix-offline-get branch June 27, 2022 17:56
@maneesht maneesht mentioned this pull request Jun 27, 2022
Closed
This was referenced Jul 6, 2022
Merged
Merged
@maneesht maneesht mentioned this pull request Jul 19, 2022
Closed
@firebase firebase locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsdt jsdt jsdt approved these changes

@jmwski jmwski jmwski approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

@allspain allspain Awaiting requested review from allspain

@markarndt markarndt Awaiting requested review from markarndt

Assignees

@hsubox76 hsubox76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"the client is offline." but it's not the case
5 participants
@maneesht @google-oss-bot @jsdt @jmwski @hsubox76